Skip to content

test: cover config loading behavior#72

Merged
ParzivalHack merged 1 commit into
ParzivalHack:mainfrom
ynachiket:ynachiket/test-config-65-20260605
Jun 6, 2026
Merged

test: cover config loading behavior#72
ParzivalHack merged 1 commit into
ParzivalHack:mainfrom
ynachiket:ynachiket/test-config-65-20260605

Conversation

@ynachiket
Copy link
Copy Markdown
Contributor

Summary

  • add dedicated unit coverage for config.py per Good First Issue: Write unit tests for config.py #65
  • cover valid TOML loading, missing/invalid config fallback, and default copy isolation
  • cover packaged default rule loading, AI rule inclusion, and shared placeholder substitution

Validation

  • /tmp/pyspector-pdlc048-venv/bin/python -m pytest tests/unit/test_config.py -q
  • /tmp/pyspector-pdlc048-venv/bin/python -m py_compile src/pyspector/config.py tests/unit/test_config.py
  • /tmp/pyspector-pdlc048-venv/bin/python -m ruff check src/pyspector/config.py tests/unit/test_config.py
  • git diff --check

Fixes #65

Copy link
Copy Markdown
Owner

@ParzivalHack ParzivalHack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ynachiket, thanks for the PR and great idea adding deepcopy to prevent nesting/mutation bugs! Merging :D

@ParzivalHack ParzivalHack added enhancement New feature or request Test Label for every issue related to tests and testing in general labels Jun 6, 2026
@ParzivalHack ParzivalHack merged commit 70eac6a into ParzivalHack:main Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Test Label for every issue related to tests and testing in general

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Good First Issue: Write unit tests for config.py

2 participants