-
Notifications
You must be signed in to change notification settings - Fork 0
Version Up #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Up #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the version to 1.0.11 and introduces several feature enhancements and architectural improvements to the image editing application. The main changes focus on making the padding feature configurable, adding watermark preview functionality, and refactoring the event system to use an event bridge pattern for better separation of concerns.
- Adds configurable padding size input with dynamic preview
- Implements watermark preview image display before application
- Refactors layer event handling to use an IPC-based event bridge pattern, removing tight coupling between ImageLayer and ImgKitRenderer
- Updates dependencies including sharp and related packages to latest patch versions
Reviewed Changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Version bumped from 1.0.10 to 1.0.11 |
| package-lock.json | Updated version and various sharp-related dependencies to latest patch versions |
| renderer/paint_renderer.js | Added watermark preview image initialization and configurable pad size input handler |
| renderer/main_renderer.js | Updated to receive and use dynamic padSize value from paint panel |
| pages/paint_panel.html | Added watermark preview image element and pad size number input |
| main.js | Updated pad image request handler to forward padSize parameter; added event relay for layer events |
| imgkit/features/image_mode.js | Adjusted color picker cursor hotspot from 32 to 24 pixels |
| imgkit/features/image_layer_events.js | Refactored to send layer events via IPC instead of directly calling renderer methods; removed unused webUtils import |
| imgkit/core/main_renderer.js | Added event bridge system to handle layer events; implemented helper methods for layer operations by ID |
| imgkit/core/image_layer.js | Removed renderer dependency from constructor; added unique layer ID system; updated to send events via IPC |
| imgkit/assets/spoid.png | Updated eyedropper cursor image (binary file) |
| imgkit/README.md | Updated example code to reflect constructor signature change |
| css/panel.css | Added space-between justification to wrapperBox for better element spacing |
| css/paint_panel.css | Added styles for watermark preview image and pad value input |
Comments suppressed due to low confidence (1)
imgkit/core/image_layer.js:35
- This write to property 'isDefault' is useless, since another property write always overrides it.
this.isDefault = isDefault; // Is this a placeholder "+ Add Image" layer?
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.