Skip to content

Conversation

@Free-Pascal-meets-SDL-Website
Copy link
Contributor

Basically the test program testver.pas uses all the inc-files and proves SDL3.pas is working.

In SDL_log.inc there is one variadic argument av_list which I left out. I will start an issue about this.

@Free-Pascal-meets-SDL-Website Free-Pascal-meets-SDL-Website merged commit c77d8a8 into PascalGameDevelopment:main Dec 30, 2024
Copy link
Contributor

@suve suve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not reviewing this earlier, but, well, holidays. A few points we might want to discuss briefly before moving forward.

type
PPSDL_AppResult = ^PSDL_AppResult;
PSDL_AppResult = ^TSDL_AppResult;
TSDL_AppResult = Integer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a cint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Sorry for not waiting before you reviewed this PR, but the next one relies on this and I wanted to prevent to merge a branch off a branch, just for simplicity.)

My answer is in issue #5 for discussion.

@Free-Pascal-meets-SDL-Website Free-Pascal-meets-SDL-Website deleted the add-sdl3-init-log-version-revision branch August 15, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants