feat: Update readme and add a few examples #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottmarchant
commented
Dec 8, 2025
| }() | ||
|
|
||
| @preconcurrency | ||
| public func shutdownGracefully(_ callback: @escaping @Sendable (Error?) -> Void = { _ in }) { |
Collaborator
Author
There was a problem hiding this comment.
This changes brings the implementation more in line with the NIOPosix implementation. The changes in NIOTreadPoolTests were required after making this change, which is good, because this default parameter hid the async API.
scottmarchant
requested review from
CrownedPhoenix,
karloscarweber and
krodak
60 tasks
krodak
approved these changes
Dec 9, 2025
karloscarweber
approved these changes
Dec 9, 2025
…OPosix which prevented calling the async variation.
scottmarchant
force-pushed
the
feat/updateReadmeAndExamples
branch
from
843af50 to
9fa4919
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Adds a much more extensive README, some examples, and a few necessary API adjustments discovered while implementing the examples.
Change Details
Note: This PR contains a breaking API change, but NIOAsyncRuntime has never been released yet, so it is fine.