-
Notifications
You must be signed in to change notification settings - Fork 0
Overview of Entire NIOAsyncRuntime Implementation #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
scottmarchant
wants to merge
11
commits into
main
Choose a base branch
from
feat/swift-wasm-support-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,344
−8
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4820791
build: Initial commit of swift package init with package name nio-asy…
scottmarchant 7a43865
build: Add dependencies used by NIOAsyncRuntime.
scottmarchant e070adc
feat: Add AsyncEventLoopExecutor that forms the foundation for creati…
scottmarchant 4b332bd
feat: Add testing utilities that make a number of nio-related tests m…
scottmarchant f29a0b9
feat: Implement AsynceEventLoop and MultiThreadedEventLoopGroup using…
scottmarchant 22b45a3
test: Add tests for AsyncEventLoop and AsyncEventLoopExecutor. The va…
scottmarchant 71e80a1
test: Add tests for MultiThreadedEventLoopGroup in NIOAsyncRuntime. T…
scottmarchant 0906089
feat: Implement NIOThreadPool using swift concurrency
scottmarchant 72a692f
test: Add tests for NIOThreadPool
scottmarchant 1b28ae0
test: Add tests for EventLoopFuture usages, ported from swift-nio to …
scottmarchant 24a2d65
ci: Set up basic pull request CI using https://github.com/PassiveLogi…
scottmarchant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| name: Pull request | ||
|
|
||
| on: | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please don't review this PR. Review the small PR's. This larger PR is just an aid in case seeing everything at once is helpful. |
||
| pull_request: | ||
| types: [opened, reopened, synchronize] | ||
|
|
||
| jobs: | ||
| soundness: | ||
| name: Soundness | ||
| uses: swiftlang/github-workflows/.github/workflows/soundness.yml@main | ||
| with: | ||
| format_check_container_image: swift:6.1.0-noble | ||
| license_header_check_enabled: false | ||
| api_breakage_check_enabled: false | ||
|
|
||
| tests: | ||
| name: Tests | ||
| uses: swiftlang/github-workflows/.github/workflows/swift_package_test.yml@main | ||
| with: | ||
| enable_macos_checks: false | ||
| linux_exclude_swift_versions: "[{\"swift_version\": \"5.9\"}, {\"swift_version\": \"5.10\"}, {\"swift_version\": \"5.10.1\"}, {\"swift_version\": \"6.0\"}]" | ||
| enable_windows_checks: false | ||
| enable_wasm_sdk_build: true | ||
| enable_embedded_wasm_sdk_build: false | ||
|
|
||
| wasm-sdk: | ||
| name: WebAssembly SDK | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: "swift:6.1.0-noble" | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| - name: Swift version | ||
| run: swift --version | ||
| - name: WasmBuild | ||
| run: | | ||
| apt-get update -y -q | ||
| apt-get install -y -q curl | ||
| apt-get install -y -q jq | ||
| version="$(swift --version | head -n1)" | ||
| tag="$(curl -sL "https://raw.githubusercontent.com/swiftwasm/swift-sdk-index/refs/heads/main/v1/tag-by-version.json" | jq -e -r --arg v "$version" '.[$v] | .[-1]')" | ||
| curl -sL "https://raw.githubusercontent.com/swiftwasm/swift-sdk-index/refs/heads/main/v1/builds/$tag.json" | jq -r '.["swift-sdks"]["wasm32-unknown-wasi"] | "swift sdk install \"\(.url)\" --checksum \"\(.checksum)\""' | sh -x | ||
| swift build --swift-sdk wasm32-unknown-wasi | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| // swift-tools-version: 6.0 | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // Copyright (c) 2025 PassiveLogic, Inc. | ||
| // Licensed under Apache License v2.0 | ||
| // | ||
| // See LICENSE.txt for license information | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import PackageDescription | ||
|
|
||
| let package = Package( | ||
| name: "nio-async-runtime", | ||
| products: [ | ||
| .library( | ||
| name: "NIOAsyncRuntime", | ||
| targets: ["NIOAsyncRuntime"] | ||
| ) | ||
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/apple/swift-atomics.git", from: "1.1.0"), | ||
| .package(url: "https://github.com/apple/swift-nio.git", from: "2.89.0"), | ||
| ], | ||
| targets: [ | ||
| .target( | ||
| name: "NIOAsyncRuntime", | ||
| dependencies: [ | ||
| .product(name: "Atomics", package: "swift-atomics"), | ||
| .product(name: "NIOCore", package: "swift-nio"), | ||
| ], | ||
| ), | ||
| .testTarget( | ||
| name: "NIOAsyncRuntimeTests", | ||
| dependencies: [ | ||
| "NIOAsyncRuntime", | ||
| .product(name: "NIOConcurrencyHelpers", package: "swift-nio"), | ||
| .product(name: "NIOCore", package: "swift-nio"), | ||
| .product(name: "NIOFoundationCompat", package: "swift-nio"), | ||
| .product(name: "NIOTestUtils", package: "swift-nio"), | ||
| ], | ||
| ), | ||
| ] | ||
| ) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't merge this PR. It is meant to show all changes together