Closed
Conversation
PatOConnor43
force-pushed
the
fix-test
branch
from
cbdcc02 to
2cd7c6a
Compare
PatOConnor43
force-pushed
the
fix-test
branch
from
2cd7c6a to
d88e289
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey I noticed that there were some failing tests due to some type issues. I've been trying to fix them all for the dart:stable build but I've had a ton of trouble getting "test/controller_test.dart: controller in group" to pass with the ANGEL_ENV=production flag. Do you have any ideas why that would fail? All the tests pass in dart:stable without this flag.