This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Implement SaplingGrowTreeEvent and BlockEvent.FarmlandTrampleEvent #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitlith
approved these changes
Jul 24, 2020
Contributor
kitlith
left a comment
kitlith
left a comment
There was a problem hiding this comment.
Other than the documentation nit, this LGTM.
Comment on lines
29
to
39
| * SaplingGrowTreeEvent is fired when a sapling grows into a tree.<br> | ||
| * This event is fired during sapling growth in | ||
| * {@link net.minecraft.block.SaplingBlock#generate(IWorld, BlockPos, BlockState, Random)}.<br> | ||
| * <br> | ||
| * {@link #pos} contains the coordinates of the growing sapling. <br> | ||
| * {@link #rand} contains an instance of Random for use. <br> | ||
| * <br> | ||
| * This event is not cancellable.<br> | ||
| * <br> | ||
| * This event has a result.<br> | ||
| * This result determines if the sapling is allowed to grow. <br> |
Contributor
There was a problem hiding this comment.
IIRC generally we turn Forge's use of linebreaks into proper paragraphs.
TheGlitch76
suggested changes
Jul 26, 2020
patchwork-events-world/src/main/java/net/minecraftforge/event/world/BlockEvent.java
Show resolved
Hide resolved
Comment on lines
29
to
39
| * SaplingGrowTreeEvent is fired when a sapling grows into a tree.<br> | ||
| * This event is fired during sapling growth in | ||
| * {@link net.minecraft.block.SaplingBlock#generate(IWorld, BlockPos, BlockState, Random)}.<br> | ||
| * <br> | ||
| * {@link #pos} contains the coordinates of the growing sapling. <br> | ||
| * {@link #rand} contains an instance of Random for use. <br> | ||
| * <br> | ||
| * This event is not cancellable.<br> | ||
| * <br> | ||
| * This event has a result.<br> | ||
| * This result determines if the sapling is allowed to grow. <br> |
| } | ||
|
|
||
| public static boolean onFarmlandTrample(World world, BlockPos pos, BlockState state, float fallDistance, Entity entity) { | ||
| //TODO: In forge, the possibility of trampling is handled by IForgeEntity.canTrample |
Member
There was a problem hiding this comment.
Suggested change
| //TODO: In forge, the possibility of trampling is handled by IForgeEntity.canTrample | |
| // TODO: In forge, the possibility of trampling is handled by IForgeEntity.canTrample |
TheGlitch76
reviewed
Jul 29, 2020
patchwork-events-world/src/main/java/net/minecraftforge/event/world/SaplingGrowTreeEvent.java
Show resolved
Hide resolved
TheGlitch76
previously approved these changes
Jul 29, 2020
Member
|
Please resolve merge conflicts |
Member
|
Failing checkstyle |
Member
|
Lots and lots of merge conflicts and a failing checkstyle |
…-farmland # Conflicts: # patchwork-god-classes/src/main/java/net/minecraftforge/common/ForgeHooks.java
Fix checkstyle and merge conflicts for feature/sapling-and-farmland
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of these events are required for CoFH Core. Doing them in the same PR as they're both relatively simple.