This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Implement ProjectileImpactEvent#168
Merged
TheGlitch76 merged 1 commit intoPatchworkMC:masterfrom Aug 2, 2020
WalkerKnapp:feature/projectileimpactevent
Merged
Implement ProjectileImpactEvent#168TheGlitch76 merged 1 commit intoPatchworkMC:masterfrom WalkerKnapp:feature/projectileimpactevent
TheGlitch76 merged 1 commit intoPatchworkMC:masterfrom
WalkerKnapp:feature/projectileimpactevent
Conversation
TheGlitch76
approved these changes
Aug 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pretty simple PR to implement Forge's ProjectileImpactEvent.
This uses 2
@Redirects, intoExplosiveProjectileEntityandShulkerBulletEntity, but this is the best way I could find to implement the original patches while maintaining behavior. If anyone has other ideas for how to implement these, I would appreciate it.Corresponding patchwork-testmods PR: PatchworkMC/patchwork-testmods#3