This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Make CapabilityRegisteredCallback store class names not class objects#175
Merged
TheGlitch76 merged 1 commit intomasterfrom Aug 11, 2020
Merged
Make CapabilityRegisteredCallback store class names not class objects#175TheGlitch76 merged 1 commit intomasterfrom
TheGlitch76 merged 1 commit intomasterfrom
Conversation
ramidzkh
approved these changes
Aug 11, 2020
TheGlitch76
reviewed
Aug 11, 2020
| } | ||
|
|
||
| static <C> Event<CapabilityRegisteredCallback<C>> event(String className) { | ||
| return CapabilityRegisteredCallbackInternal.getOrCreateEvent(className); |
Member
There was a problem hiding this comment.
I'm not confident we should allow arbitrary strings, but i guess in the long run it's really not that big of a deal
TheGlitch76
approved these changes
Aug 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed so the CapabilityInject handling in Patcher doesn't have to load types onto the stack, and replicate Forge behavior of not needing a CapabilityInject's type to exist at runtime.