This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Implement ClientPlayerNetworkEvent#177
Merged
TheGlitch76 merged 3 commits intoPatchworkMC:masterfrom Aug 14, 2020
WalkerKnapp:feature/clientplayernetworkevent
Merged
Implement ClientPlayerNetworkEvent#177TheGlitch76 merged 3 commits intoPatchworkMC:masterfrom WalkerKnapp:feature/clientplayernetworkevent
TheGlitch76 merged 3 commits intoPatchworkMC:masterfrom
WalkerKnapp:feature/clientplayernetworkevent
Conversation
Contributor
|
I would like to suggest that you should move ClientHooks from the networking module to the god-classes module: |
Contributor
Author
|
Done 👍 |
TheGlitch76
approved these changes
Aug 14, 2020
Member
TheGlitch76
left a comment
TheGlitch76
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements ClientPlayerNetworkEvent in patchwork-networking.
I am still unsure about if this is the best package to use for this event, so if it would be better to use another mod or to create a new one, just let me know.
Corresponding testmods PR: PatchworkMC/patchwork-testmods#4