This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Fix item pickup events#193
Merged
TheGlitch76 merged 1 commit intomasterfrom Oct 24, 2020
Merged
Conversation
ZNixian
reviewed
Oct 20, 2020
Comment on lines
+68
to
+69
| at = @At(value = "INVOKE", target = "Lnet/minecraft/item/ItemStack;getCount()I"), | ||
| cancellable = true |
Member
There was a problem hiding this comment.
These lines are being re-indented - any particular reason?
TheGlitch76
approved these changes
Oct 24, 2020
Member
TheGlitch76
left a comment
TheGlitch76
left a comment
There was a problem hiding this comment.
Sorry for taking so long! The indention is a little funky on this but it's a pretty bad bug so i'll leave it to be fixed Later:tm:
Please bother me on Discord about PR reviews if I don't even remark that I'm waiting on something, it's very likely I've just forgotten about it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EntityItemPickupEvent and PlayerEvent.ItemPickupEvent were implemented incorrectly, leading to no items being able to be picked up and events firing at times they shouldn't. This PR fixes the implementation of these two events.