This repository was archived by the owner on Jun 3, 2024. It is now read-only.
LivingFallEvent and PlayerFlyableFallEvent#33
Merged
coderbot16 merged 15 commits intoPatchworkMC:masterfrom Feb 17, 2020
IceCryptonym:master
Merged
LivingFallEvent and PlayerFlyableFallEvent#33coderbot16 merged 15 commits intoPatchworkMC:masterfrom IceCryptonym:master
coderbot16 merged 15 commits intoPatchworkMC:masterfrom
IceCryptonym:master
Conversation
coderbot16
suggested changes
Jan 26, 2020
Member
coderbot16
left a comment
coderbot16
left a comment
There was a problem hiding this comment.
Please fix checkstyle and use tabs instead of spaces. There's also a few things that I would like to be fixed. Thanks for contributing!
added 5 commits
January 27, 2020 09:51
coderbot16
suggested changes
Jan 31, 2020
Member
coderbot16
left a comment
coderbot16
left a comment
There was a problem hiding this comment.
Your implementation is spot-on, just some nitpicks to naming and javadoc.
added 3 commits
January 31, 2020 23:29
Contributor
Author
|
I apologize for the mess in commits. I'm still learning how to use git. |
Contributor
|
Don't worry it is better than me naming commits abc |
Member
|
Please fix licensing errors (2020) and this is good to merge |
Member
|
Looks like merging kitlith's PR created merge conflicts, sorry. Please fix them and then I'll merge this. |
coderbot16
suggested changes
Feb 17, 2020
Member
coderbot16
left a comment
coderbot16
left a comment
There was a problem hiding this comment.
Uh... didn't notice before, but could you restore .gitignore and remove the .vscode files? Then this will finally be ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements fall events from #29. One thing I am uncertain about is how I should have gone about
onLivingFall(), when injecting into the methods. I have to modify two local variables at once becauseonLivingFall()returns afloat[]. If you know of a better way, I'd like to know. : )I believe this will work, I tested it and it seems to do as expected.