Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Conversation

@jaskarth
Copy link
Contributor

Closes #54

Adds forge's tool type system. Tested with this mod

Copy link
Member

@TheGlitch76 TheGlitch76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks on fixing up weird Forge style.
Also, if you could go ahead and implement the tooltypes onto vanilla classes that would be cool but not needed for a merge

Co-authored-by: Glitch <glitchieproductionsofficial@gmail.com>
@TheGlitch76
Copy link
Member

@SuperCoder7979 if you can just drop it in a shared module and resolve my comment this is OK for merge.
Obviously having its own module is nasty but it can be merged with another one later.

@valoeghese
Copy link
Contributor

Hi can you finish this we need it for BOP

@TheGlitch76 TheGlitch76 added the in progress This is being worked on and is not ready for final review label Jun 23, 2020
kitlith added 2 commits June 23, 2020 15:42
Use HashMap constructor instead of Maps method
@TheGlitch76
Copy link
Member

scoder said he would finish this in discord but ok

@TheGlitch76 TheGlitch76 requested a review from coderbot16 June 24, 2020 01:06
@valoeghese
Copy link
Contributor

valoeghese commented Jun 28, 2020

There was once a tooltypes pr
It has been waiting 4 days so far
for the coderbot
has decided not
to add this to the mod jARR

@valoeghese
Copy link
Contributor

sudo merge #73

@kitlith
Copy link
Contributor

kitlith commented Jun 28, 2020

@valoeghese if you want you can just click the merge button. It seems like a pretty simple PR (i don't see anything wrong with it) so assuming I didn't mess up the module stuff it should be okay. we can always fix stuff later. i have no pressing need, so i can wait.

You can also pull this change into your local copy so you can work with BOP before the PR is merged.

otherwise, if you're not going to merge it yourself, then please stop commenting here. every time i see a message for this pr i'm hoping it's a review or feedback or something and your 'pls merge' is both disappointing and not helping.

@TheGlitch76 TheGlitch76 merged commit 05ceb6f into master Jun 28, 2020
@valoeghese
Copy link
Contributor

I don’t have merge perms lol

@valoeghese
Copy link
Contributor

Also my nagging is 90% just me being silly

@valoeghese
Copy link
Contributor

I have an... unusual personality 🤔

@florensie florensie deleted the feature/tool-types branch June 30, 2020 21:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

in progress This is being worked on and is not ready for final review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement ToolTypes

6 participants