-
Notifications
You must be signed in to change notification settings - Fork 47
add tool types #73
add tool types #73
Conversation
TheGlitch76
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks on fixing up weird Forge style.
Also, if you could go ahead and implement the tooltypes onto vanilla classes that would be cool but not needed for a merge
patchwork-extensions-item/src/main/java/net/minecraftforge/common/ToolType.java
Outdated
Show resolved
Hide resolved
patchwork-extensions-item/src/main/java/net/minecraftforge/common/ToolType.java
Outdated
Show resolved
Hide resolved
patchwork-extensions-item/src/main/java/net/minecraftforge/common/ToolType.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Glitch <glitchieproductionsofficial@gmail.com>
patchwork-extensions-item/src/main/java/net/minecraftforge/common/ToolType.java
Show resolved
Hide resolved
|
@SuperCoder7979 if you can just drop it in a shared module and resolve my comment this is OK for merge. |
|
Hi can you finish this we need it for BOP |
Use HashMap constructor instead of Maps method
|
scoder said he would finish this in discord but ok |
|
There was once a tooltypes pr |
|
sudo merge #73 |
|
@valoeghese if you want you can just click the merge button. It seems like a pretty simple PR (i don't see anything wrong with it) so assuming I didn't mess up the module stuff it should be okay. we can always fix stuff later. i have no pressing need, so i can wait. You can also pull this change into your local copy so you can work with BOP before the PR is merged. otherwise, if you're not going to merge it yourself, then please stop commenting here. every time i see a message for this pr i'm hoping it's a review or feedback or something and your 'pls merge' is both disappointing and not helping. |
|
I don’t have merge perms lol |
|
Also my nagging is 90% just me being silly |
|
I have an... unusual personality 🤔 |
Closes #54
Adds forge's tool type system. Tested with this mod