Skip to content

Port item comparison features from PoB 1: enchant copy and jewel socket sorting#1798

Open
vaisest wants to merge 3 commits intoPathOfBuildingCommunity:devfrom
vaisest:item-comparison-ports
Open

Port item comparison features from PoB 1: enchant copy and jewel socket sorting#1798
vaisest wants to merge 3 commits intoPathOfBuildingCommunity:devfrom
vaisest:item-comparison-ports

Conversation

@vaisest
Copy link
Copy Markdown

@vaisest vaisest commented Apr 17, 2026

Description of the problem being solved:

Port over eldritch implicit copying when comparing items (but for augments), and jewel socket sorting from PoB1.

Steps taken to verify a working solution:

Most augment copying scenarios were tested. For example:

  • Equipped 4 socket quarterstaff:
    • 3 socket mirrored/sanctified/corrupted -> 3 first runes are copied, no socket added
    • 4 socket quarterstaff -> all runes are copied
    • uncorrupted quarterstaff -> 4 sockets added and runes copied (not sure if this is the best way, considering this implies exceptional + corruption)
    • corrupted 0 socket -> nothing happens
  • amulets: anoints are only copied if the item is modifiable and current amulet has an anoint. Otherwise they are unchanged.
  • Tabula Rasa should not have runes copied to it.
  • Dual wield maces: runes are copied from the first (left) weapon.
  • Copying from darkness enthroned doesn't work as it doesn't seem to support using runes in pob.
  • Invalid runes shouldn't be copied. For example wand +level doesn't get copied to a mace.
  • Shields and focuses copy from weapon slot 2.

Jewel sockets in comparisons are now sorted by:

  1. empty sockets
  2. same base group jewel (timeless or regular) or unique (only compatible jewel being grand spectrum atm)
  3. DPS
  4. EHP
  5. Slot

Link to a build that showcases this PR:

Random adorned build from Poe.ninja: https://poe.ninja/poe2/builds/vaal/character/BansheesVeil-4479/sotsunakuPFfov?i=0&search=items%3DThe%2BAdorned

Augment copy: https://pobb.in/scdCmAvzGvQk

Poe.ninja dual wield build: https://poe.ninja/poe2/builds/vaal/character/DHK06-7075/LILNEAR?i=1&search=weaponmode%3DDual%2BTwo%2BHanded%2BMace%252CDual%2BMace

Before screenshot:

image image

After screenshot:

image image

@vaisest vaisest force-pushed the item-comparison-ports branch from 8fae041 to 7ee6401 Compare April 18, 2026 01:05
@vaisest vaisest marked this pull request as ready for review April 18, 2026 01:51
@vaisest vaisest marked this pull request as draft April 18, 2026 02:10
@vaisest vaisest force-pushed the item-comparison-ports branch from a890f6b to 17cec65 Compare April 18, 2026 02:29
@vaisest vaisest marked this pull request as ready for review April 18, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant