Skip to content

Fix increased Enemy damage taken mods doubling their affect in Ailment calcs#1819

Merged
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
Andrew-Klotz:fix-ailment-calc
May 26, 2026
Merged

Fix increased Enemy damage taken mods doubling their affect in Ailment calcs#1819
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
Andrew-Klotz:fix-ailment-calc

Conversation

@Andrew-Klotz
Copy link
Copy Markdown
Contributor

Fixes bug with no outstanding issue.

Description of the problem being solved:

Increases/more damage taken on enemies is double counted for physical/chaos ailments (bleed and poison). E.g., Nearby enemies take 10% increased chaos damage results in a 20% increase in the calculations.

Steps taken to verify a working solution:

Confirmed physical/chaos work properly for bleed/poison respectively, while elemental still works for ignite.

Link to a build that showcases this PR:

https://pobb.in/UCOPSE85Cyoz

Before screenshot:

image

After screenshot:

image

Andrew Klotz and others added 2 commits May 8, 2026 14:58
The mod was only there to handle elemental damage taken mods so now it is simplified
Also adds a test to make sure it works correctly
@Andrew-Klotz
Copy link
Copy Markdown
Contributor Author

Looks good to me. I kept the ailmentTypeMod path as future proofing for other generic damage modifiers that could be added (e.g. non-chaos), but currently the game only has elemental so your cleaner fix works.

As for testing, didn't add any as I was unsure on testing philosophy (test count looks fairly light given the project size, and contributing.md just mentions adding testing for new features) and didn't know how much of a performance bottleneck there might be on testing. Depending on philosophy, it might be worth considering adding testing for increased phys for bleed and increased fire/elemental for ignite. Current dev has the same double-count for phys bleed as for chaos poison.

@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label May 26, 2026
@LocalIdentity LocalIdentity changed the title Added de-duping to ailment type calculation to fix double counting bleed and poison. Fix increased Enemy damage taken mods doubling their affect in Ailment calcs May 26, 2026
@LocalIdentity LocalIdentity merged commit 0f81708 into PathOfBuildingCommunity:dev May 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants