Add support for Jarngreipr's Strength mod#1871
Merged
LocalIdentity merged 3 commits intoMay 18, 2026
Merged
Conversation
LocalIdentity
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adds support for "Strength can satisfy other Attribute Requirements of Melee Weapons and Melee Skills". Similar code location as Gemling's Adaptive Capability.
Added a test against an Int melee weapon and Dex melee skill before and after equipping Jarngreipr, also added a quick check for Gemling's ascendancy.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
After screenshot:
Primal Strikes
No warnings
Chober Chaber
No warnings
Still showing issues for other items
Warnings
