Fix Item granted skills not showing up as Implicits when pasting#1873
Merged
LocalIdentity merged 1 commit intoMay 19, 2026
Conversation
LocalIdentity
approved these changes
May 19, 2026
f860ca5
into
PathOfBuildingCommunity:dev
2 of 3 checks passed
LocalIdentity
pushed a commit
that referenced
this pull request
May 20, 2026
Contributor
|
|
Contributor
|
@cbui now fixed on dev. Thanks for letting me know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Root Cause
Grants Skill: ...as a normal explicit/unknown line.Grants Skill: Spear Throwcould be misclassified instead of detected as the base-granted skill.Fix
Validation
git diff --checklupa.busted --lua=luajit ../spec/System/TestItemParse_spec.lua25 successes / 0 failures / 0 errors / 0 pending : 0.329 secondsdocker-compose upRisk / Rollback
Fixes #1728