Fix Uhtred supports counting Meta gems as supports#1896
Merged
LocalIdentity merged 2 commits intoMay 20, 2026
Merged
Conversation
LocalIdentity
approved these changes
May 20, 2026
LocalIdentity
pushed a commit
that referenced
this pull request
May 21, 2026
Should have been included in #1896
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1734
Summary
Hidden internal supports from meta gems no longer increment
Multiplier:SupportCountfor the supported active skill.Root Cause
CalcActiveSkillcounted every supporting granted effect inactiveSkill.effectListas a connected support. Meta gems such as Cast on Critical also inject hidden internal support effects likeSupportMetaCastOnCritPlayer. Those hidden effects are real calculation helpers, but they are not player-connected support gems and should not satisfy or break support-count thresholds.For Uhtred lineage supports, that extra hidden support changed the count from the in-game value of 2 to 3, preventing
Uhtred's Omenfrom granting its level bonus in meta-gem setups.Fix
Keep merging hidden support effects as before, but exclude
grantedEffect.hiddensupports fromMultiplier:SupportCount.This preserves the hidden trigger support behavior while making support-count conditions reflect visible connected support gems.
Validation
Cast on Critical + Arc + Uhtred's Omen + Rising Tempest:+3gem support level.git diff --checkbefore commit: pass.git diff --cached --checkbefore commit: pass.git show --check --stat --oneline HEAD: pass.I did not run
docker-compose uplocally to avoid launching Docker/extra windows on this machine; the change is covered by the targeted Busted spec and should run in CI.Risk / Rollback
Risk is low: only the support-count multiplier excludes hidden support effects. Hidden supports are still merged and can still provide trigger behavior, mana/reservation modifiers, and other calculation data.
Rollback is the single commit if any hidden support is found that intentionally should count as a player-connected support.