Skip to content

Fix Uhtred supports counting Meta gems as supports#1896

Merged
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/hidden-support-count
May 20, 2026
Merged

Fix Uhtred supports counting Meta gems as supports#1896
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/hidden-support-count

Conversation

@unrealdreamz
Copy link
Copy Markdown
Contributor

Fixes #1734

Summary

Hidden internal supports from meta gems no longer increment Multiplier:SupportCount for the supported active skill.

Root Cause

CalcActiveSkill counted every supporting granted effect in activeSkill.effectList as a connected support. Meta gems such as Cast on Critical also inject hidden internal support effects like SupportMetaCastOnCritPlayer. Those hidden effects are real calculation helpers, but they are not player-connected support gems and should not satisfy or break support-count thresholds.

For Uhtred lineage supports, that extra hidden support changed the count from the in-game value of 2 to 3, preventing Uhtred's Omen from granting its level bonus in meta-gem setups.

Fix

Keep merging hidden support effects as before, but exclude grantedEffect.hidden supports from Multiplier:SupportCount.

This preserves the hidden trigger support behavior while making support-count conditions reflect visible connected support gems.

Validation

  • Added a regression test for Cast on Critical + Arc + Uhtred's Omen + Rising Tempest:
    • Arc support count remains 2.
    • Uhtred's Omen grants +3 gem support level.
  • Ran git diff --check before commit: pass.
  • Ran git diff --cached --check before commit: pass.
  • Ran git show --check --stat --oneline HEAD: pass.

I did not run docker-compose up locally to avoid launching Docker/extra windows on this machine; the change is covered by the targeted Busted spec and should run in CI.

Risk / Rollback

Risk is low: only the support-count multiplier excludes hidden support effects. Hidden supports are still merged and can still provide trigger behavior, mana/reservation modifiers, and other calculation data.

Rollback is the single commit if any hidden support is found that intentionally should count as a player-connected support.

@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label May 20, 2026
@LocalIdentity LocalIdentity changed the title Fix hidden meta support counting Fix Uhtred supports counting Meta gems as supports May 20, 2026
@LocalIdentity LocalIdentity merged commit 6eff90c into PathOfBuildingCommunity:dev May 20, 2026
3 checks passed
LocalIdentity pushed a commit that referenced this pull request May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uhtred supports counting Meta gems as Support Gems when determining whether their effect applies or not.

2 participants