Skip to content

Gate Barrage incorrectly granting damage to some skills#1897

Merged
LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/barrageable-repeat-gate
May 20, 2026
Merged

Gate Barrage incorrectly granting damage to some skills#1897
LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/barrageable-repeat-gate

Conversation

@unrealdreamz
Copy link
Copy Markdown
Contributor

Fixes #547

Summary

Barrage repeat DPS now applies only to skills tagged SkillType.Barrageable.

Root Cause

The Barrage buff adds SequentialProjectiles/BarrageRepeats globally, and the offence calculation used those flags to apply the Barrage repeat DPS path to the active skill.

That path did not check whether the active skill itself is Barrageable. Spiral Volley is a bow projectile skill, but it is not tagged SkillType.Barrageable, so it should not consume/apply Barrage in-game.

Fix

Introduce a local canBarrageRepeat gate that keeps the existing SequentialProjectiles, OneShotProj, NoAdditionalProjectiles, and TriggeredBySnipe checks, and also requires:

activeSkill.skillTypes[SkillType.Barrageable]

This fixes the rule boundary rather than adding a one-off Spiral Volley exception.

Validation

  • Added a regression test for Spiral Volley: adding Barrage does not change its TotalDPS.
  • Added a positive control for Ice Shot: adding Barrage still increases TotalDPS for a Barrageable skill.
  • Ran git diff --check before commit: pass.
  • Ran git diff --cached --check before commit: pass.
  • Ran git show --check --stat --oneline HEAD: pass.

I did not run docker-compose up locally to avoid launching Docker/extra windows on this machine; the targeted Busted spec should run in CI.

Risk / Rollback

Risk is low: this narrows Barrage repeat handling to skills already marked Barrageable in exported skill data. The positive-control test protects the intended Barrage path.

Rollback is the single commit if a valid Barrage-consuming skill is missing the Barrageable tag in data; that would be a data issue to correct explicitly.

@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label May 20, 2026
@LocalIdentity LocalIdentity changed the title Gate Barrage repeats to Barrageable skills Gate Barrage incorrectly granting damage to some skills May 20, 2026
@LocalIdentity LocalIdentity merged commit bbbd03f into PathOfBuildingCommunity:dev May 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spiral Volley gains additional damage from Barrage in PoB, when it shouldn't

2 participants