Gate Barrage incorrectly granting damage to some skills#1897
Merged
LocalIdentity merged 3 commits intoMay 20, 2026
Merged
Conversation
LocalIdentity
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #547
Summary
Barrage repeat DPS now applies only to skills tagged
SkillType.Barrageable.Root Cause
The Barrage buff adds
SequentialProjectiles/BarrageRepeatsglobally, and the offence calculation used those flags to apply the Barrage repeat DPS path to the active skill.That path did not check whether the active skill itself is Barrageable.
Spiral Volleyis a bow projectile skill, but it is not taggedSkillType.Barrageable, so it should not consume/apply Barrage in-game.Fix
Introduce a local
canBarrageRepeatgate that keeps the existingSequentialProjectiles,OneShotProj,NoAdditionalProjectiles, andTriggeredBySnipechecks, and also requires:This fixes the rule boundary rather than adding a one-off Spiral Volley exception.
Validation
git diff --checkbefore commit: pass.git diff --cached --checkbefore commit: pass.git show --check --stat --oneline HEAD: pass.I did not run
docker-compose uplocally to avoid launching Docker/extra windows on this machine; the targeted Busted spec should run in CI.Risk / Rollback
Risk is low: this narrows Barrage repeat handling to skills already marked Barrageable in exported skill data. The positive-control test protects the intended Barrage path.
Rollback is the single commit if a valid Barrage-consuming skill is missing the Barrageable tag in data; that would be a data issue to correct explicitly.