Skip to content

Fix Palm skills not using Quarterstaff Damage and Crit#1903

Merged
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/palm-skills-quarterstaff-damage
May 20, 2026
Merged

Fix Palm skills not using Quarterstaff Damage and Crit#1903
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
unrealdreamz:fix/palm-skills-quarterstaff-damage

Conversation

@unrealdreamz
Copy link
Copy Markdown
Contributor

Summary

Fix Palm strike skill flags so the 0.3 quarterstaff damage update is reflected in calculations.

Fixes #1684

Root Cause

The generated skill data still marked the affected Palm hit stat sets as unarmed. That sends the skills through the unarmed calculation path, replacing the equipped quarterstaff with data.unarmedWeaponData, which explains the reported 5% crit chance and very low damage on Staggering Palm.

Official 0.3.0 notes changed Killing Palm, Staggering Palm, Shattering Palm, Hand of Chayula, and Frozen Locus to deal damage based on the equipped quarterstaff. Frozen Locus was already exported as a weapon attack, but the Palm strike skills still had stale unarmed flags.

Fix

  • Removed stale unarmed flags from Hand of Chayula, Killing Palm, Shattering Palm, and Staggering Palm hit stat sets.
  • Added the missing melee flag to Staggering Palm's hit stat set.
  • Updated both exported skill source and generated skill data.
  • Added a regression proving Staggering Palm uses a Long Quarterstaff's 10% base crit and no longer reports an unarmed skill flag.

Validation

Local validation run:

git diff --check
PASS (CRLF normalization warnings only)

git diff --cached --check
PASS (CRLF normalization warnings only)

git show --check --stat --oneline HEAD
PASS (CRLF normalization warnings only)

I did not run Docker/Busted locally because the available full test runner is container-based and I was avoiding external test containers/windows during this session.

Risk / Rollback

Risk is limited to the affected Palm hit stat-set flags. This avoids changing shared unarmed or weapon calculation logic. Rollback is the single commit if exported game data later says these skills should regain unarmed-only behavior.

@LocalIdentity LocalIdentity changed the title Fix Palm skill quarterstaff damage flags Fix Palm skills not using Quarterstaff Damage and Crit May 20, 2026
@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label May 20, 2026
@LocalIdentity LocalIdentity merged commit 63a375c into PathOfBuildingCommunity:dev May 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Palm skills don't seem to have been updated with 0.3 changes to damage and crit of equipped weapon.

2 participants