Add support for Witchhunter's Sorcery Ward and Ceremonial Ablution#1963
Merged
LocalIdentity merged 7 commits intoMay 25, 2026
Conversation
LocalIdentity
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #280
Description of the problem being solved:
Adds support for the aegis-like calculations of Sorcery Ward and it's additional effect of Phys/Chaos through Ceremonial Ablution. I'm also adding a statCompare tooltip when hovering the groupEnabled to see changes when enabling or disabled whole groups, or in this particular case, a granted skill.
One hiccup is hovering over Obsessive Ritual doesn't account for the new skill and it's respective output, so it looks like it's worse to take due to the less armour and evasion, but then the EHP calcs update. Inversely, deallocating Obsessive Ritual shows a net positive change, as it's calculating Sorcery Ward without the 35% less mods, but then the EHP calcs update and it's obviously worse.
Another thing I'm trying to combat is non-Witchhunters manually adding Sorcery Ward to their builds. I'm checking for ascendancy name to apply the buff, and I could possibly check the nodeId specifically so Witchhunters who do not take Obsessive Rituals can't cheat, but I'm not sure that's worth a hardcoded nodeId.Update
Comparison on removal is now accurate, and it is restricted to the node being allocated, so only Witchhunters with Obsessive Rituals can effectively use the buff.
Link to a build that showcases this PR:
After screenshot:
--
--
--