Remove item mods not present in PoE 2#6
Merged
LocalIdentity merged 11 commits intoPathOfBuildingCommunity:devfrom Dec 21, 2024
Merged
Remove item mods not present in PoE 2#6LocalIdentity merged 11 commits intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 11 commits intoPathOfBuildingCommunity:devfrom
Conversation
remove everything in item related files, haven't touched trade stuff, class restrictions, and there is still some craft mod stuff in there still used by the enchantments.
…that were missed.
QuickStick123
force-pushed
the
remove-not-present-item-mods
branch
from
4d31a6c to
d7c0cfe
Compare
LocalIdentity
approved these changes
Dec 21, 2024
LocalIdentity
pushed a commit
that referenced
this pull request
May 6, 2025
Adds back the removed lines from #6
LocalIdentity
added a commit
that referenced
this pull request
May 6, 2025
Adds back the removed lines from #6 Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Lots of items mods aren't in PoE 2 so this is unnecessary bloat
This removes the implementation from the item classes and doesn't touch trade stuff.
veiled
delve
exarch
eater
fractured
synthesis
scourge
crucible
crafted
essence (because it isn't a special tier anymore its just a re roll of an mod type)
split
influences (shaper, elder, hunter, crusader, redeemer, warlord)
elevated influence / maven
Further stuff that could be removed are class restrictions?
Steps taken to verify a working solution:
Due to changing the {crafted} tag to {enchant} as this means prior PoB 1 items directly copied will not have there mods tagged as enchants, but it probably makes sense to change it for clarity.