Skip to content

Conversation

@Wires77
Copy link
Member

@Wires77 Wires77 commented Sep 10, 2025

Fixes #8952 .

Description of the problem being solved:

This pane would show an error when leagues weren't properly fetched, but would still allow users to find the best item on trade. There might be more we can do here to make it clear what the issue is, but removing the possibility of error for now seemed best.

Steps taken to verify a working solution:

  • Made a typo in the trade URL to force a 404 error
  • Noticed the 404 error appearing in the proper error location (could still use a UI cleanup here, but is unrelated to the core issue)
  • Noticed the "Find Best" buttons were disabled

@Wires77 Wires77 added bug Something isn't working pob2 Label for features that should be ported over to PoB-PoE2 labels Sep 10, 2025
@Wires77 Wires77 merged commit 17251cc into PathOfBuildingCommunity:dev Oct 30, 2025
2 checks passed
github-actions bot pushed a commit to PathOfBuildingCommunity/PathOfBuilding-PoE2 that referenced this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working pob2 Label for features that should be ported over to PoB-PoE2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.56.0 crashes when using the 'Trade for these items' feature

1 participant