Skip to content

Fix Poisonous Concoction Added Damage from Disabled Life Flasks #9339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix Poisonous Concoction Added Damage from Disabled Life Flasks #9339

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b09e3d
set LifeFlaskRecovery for PConc if life flask is in a disabled slot
Peechey Nov 23, 2025
78d79d3
update for multiple disabled life flasks and refactor into function
Peechey Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/Modules/CalcSetup.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,6 +791,14 @@ function calcs.initEnv(build, mode, override, specEnv)
::continue::
end

local function setLifeRecoveryFromFlasks(item) -- Poisonous Concoction
if item and item.type == "Flask" and item.base.subType == "Life" then
if item.flaskData.lifeTotal > (env.itemModDB.multipliers["LifeFlaskRecovery"] or 0) then
env.itemModDB.multipliers["LifeFlaskRecovery"] = item.flaskData.lifeTotal
end
end
end

if not env.configInput.ignoreItemDisablers then
local itemDisabled = {}
local itemDisablers = {}
Expand Down Expand Up @@ -853,6 +861,7 @@ function calcs.initEnv(build, mode, override, specEnv)
end
end
for slot in pairs(trueDisabled) do
setLifeRecoveryFromFlasks(items[slot])
items[slot] = nil
end
end
Expand All @@ -864,12 +873,7 @@ function calcs.initEnv(build, mode, override, specEnv)
if slot.active then
env.flasks[item] = true
end
if item.base.subType == "Life" then
local highestLifeRecovery = env.itemModDB.multipliers["LifeFlaskRecovery"] or 0
if item.flaskData.lifeTotal > highestLifeRecovery then
env.itemModDB.multipliers["LifeFlaskRecovery"] = item.flaskData.lifeTotal
end
end
setLifeRecoveryFromFlasks(item)
item = nil
elseif item and item.type == "Tincture" then
if slot.active then
Expand Down