Skip to content

Mc fix #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slinlee merged 2 commits into from
Nov 4, 2021
Merged

Mc fix #40

slinlee merged 2 commits into from
Nov 4, 2021

Conversation

@SaharEs
Copy link
Contributor

@SaharEs SaharEs commented Nov 4, 2021

Closes #36

@SaharEs SaharEs requested review from ejunprung and slinlee November 4, 2021 17:27
@slinlee
Copy link
Contributor

slinlee commented Nov 4, 2021

Thanks, @SaharEs . I split out the CSV task here if we want to get this fix in first. #41

ejunprung
ejunprung approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@ejunprung ejunprung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works for me.

It runs slowly as @SaharEs mentioned. Generating the CSV once at the end should help a lot but yeah, we can implement that later. This is good enough just to validate the results.

@slinlee slinlee merged commit 31e6d49 into main Nov 4, 2021
@slinlee slinlee deleted the se_fix_mc_bug branch November 4, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ejunprung ejunprung ejunprung approved these changes

@slinlee slinlee Awaiting requested review from slinlee

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MC output seems strange

4 participants

@SaharEs @slinlee @ejunprung