Test run does not update the eventbus on completion

[FollowSteph]

In RescaleExecutionProgressUpdater.update() we get a list of finishedPolicies from the database and use that later to determine what progresses to update in RunUpdateServiceImpl.updateRun(). Unfortunately we then use that list of finishedPolicies to determine which Progress to run certain code in RunUpdateServiceImpl.updateRun() and only that code fires an eventbus event. The end result is that when the Run/Policy is completed we do not fire an event up the eventbus.

Short version: The progresses do not include the completed policy and as a result the code in the last code screenshot that loops through the progresses is not called, and hence no event is fired up the eventbus to tell the UI that the policy has been completed.

---

---

---

[FollowSteph]

@slinlee @kepricon I'll leave it up to you guys to close and confirm but this is now resolved. I believe it may have been fixed as part of #390 but I'm not 100% sure. In any case it does work as part of #390.

[FollowSteph]

I was wrong, there are still cases where it's not updated.

[FollowSteph]

Upon further investigation the issue appears to be due to the fact that no policies are listed as needing to be updated when a run is completed. Specifically RescaleExecutionProgressUpdater.update() is included in the list of runs that need updating but no policies are found to need updating in getPoliciesFromProgressProvider() for that run. See image below.

Since there are no policies to update then no policies are updated, and as a result there are no policy update events to fire up the eventbus. Specifically the training list screen listens to policy updates and since there are no policy update events then the policies are not updated when a test run is completed.

We could fire a newly created Run update event but that would just be added noise and a kludge to this issue as all policies would need to listen, every row in the table would need to be updated, etc. We should instead look into why there are no policies to update from getPoliciesFromProgressProvider() when a run is completed, as in what is the bug in the thinking/algorithm we're using.

With that in mind I have some concerns on how the Complete status is determined. Specifically as it pertains to PolicyUtils.getRunStatus(). Based on the logic the status of the policy is determine by the status of the run but isn't it possible that they are not in sync. For example if I'm running a discovery and fire off a full run could they not conflict? This is outside of this ticket but it is something to consider.

UPDATE -> If you debug it with breakpoints then it will sometimes results in runs appearing. This is because another update can occur while debugging (if you take more than a minute analyzing the status of variables) and as a result it can affect the list of returned policies returned from the client depending on where your debug points are located (think multi-threaded updates).