Conversation
- Changes to existing components were kept to a minimum in order to minimise risk. - The user provides context via free-form text entry into a figure caption text box. - Article summary credits (contributing author) moved to be alongside the title. - New metadata field in the model: `caption`. - Current placeholder text: 'Figure caption (e.g. A phosphorylates B in breast cancer)'. This example may be improved. Ref. : Context #506
maxkfranz
commented
Jul 21, 2021
| 'editor-caption-textarea': true | ||
| }), | ||
| value: this.state.caption, | ||
| placeholder: `Figure caption (e.g. A phosphorylates B in breast cancer)`, |
Member
Author
There was a problem hiding this comment.
This is where the example text lives. Feel free to directly change it here with an improved placeholder.
Member
Author
There was a problem hiding this comment.
Describe the context of this article (e.g. The set of interactions connecting apoptosis to nuclear function in human breast cancer)
Closed
Member
|
Placeholders ideas:
|
jvwong
approved these changes
Jul 29, 2021
Member
jvwong
left a comment
jvwong
left a comment
There was a problem hiding this comment.
Just need a decent placeholder
Member
Author
|
Added this as a discussion item in the agenda of the next call |
Member
|
|
Member
|
|
Member
|
Hi - maybe “identify” -> “describe”
…On 9 Aug 2021, at 9:37, Jeffrey wrote:
EXTERNAL EMAIL:
[Distinct-regulation-of-bioenergetics-and-translation-by-group-I-mGluR-and-NMDAR-Biofactoid(1)]<https://user-images.githubusercontent.com/4706307/128715024-b5bf2f34-0bc3-45b7-9af5-923e205fb43b.png>
[Distinct-regulation-of-bioenergetics-and-translation-by-group-I-mGluR-and-NMDAR-Biofactoid]<https://user-images.githubusercontent.com/4706307/128715042-53de5d45-94f1-492e-ae66-f1c0fd4ac747.png>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on
GitHub<#999 (comment)>,
or
unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHRPZY6DOI25N3JWO75EX3T37KYLANCNFSM5AYMVBXQ>.
Triage notifications on the go with GitHub Mobile for
iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or
Android<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>.
|
Member
|
|
Member
Author
|
@jvwong, the conflict with your other PR has been resolved. Ready to merge, if the text is finalised |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
caption.Ref. : Context #506
Default state (empty, placeholder text, not focussed):
Editing state (with typed text, focussed):
Article summary:
Video demo:
Screen.Recording.2021-07-21.at.13.19.29.mov