Skip to content

docs: add ngx-signal-combinators#1769

Merged
jdegand merged 2 commits into
PatrickJS:gh-pagesfrom
jdegand:ngx-signal-combinators
Nov 19, 2025
Merged

docs: add ngx-signal-combinators#1769
jdegand merged 2 commits into
PatrickJS:gh-pagesfrom
jdegand:ngx-signal-combinators

Conversation

@jdegand
Copy link
Copy Markdown
Collaborator

@jdegand jdegand commented Nov 19, 2025

Summary by CodeRabbit

  • Documentation
    • Added ngx-signal-combinators reference to the Angular resources section of the documentation.
    • Added ngx-signal-combinators reference to the DOM subsection of the documentation.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 19, 2025

Walkthrough

Added ngx-signal-combinators to README.md in two places: once under the Official Resources → Angular section (after the angular-paginator entry) and once under the DOM subsection, both with identical URL and description.

Changes

Cohort / File(s) Summary
Documentation additions
README.md
Added ngx-signal-combinators entry twice with the same URL and description: once in Official Resources → Angular (after angular-paginator) and once in the DOM subsection.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Check whether the duplicate listing is intentional or should be consolidated into a single section.
  • Verify the intended target section (Official Resources → Angular vs DOM) and placement relative to angular-paginator.

Poem

🐰 I hopped in docs with nimble feet,
Listed twice for folks to meet,
In Angular and DOM I play,
One little lib that hops all day. ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'docs: add ngx-signal-combinators' clearly and concisely describes the main change: adding documentation about the ngx-signal-combinators project to the README.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2df36b9 and 72ef86e.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • README.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f6175d and 2df36b9.

📒 Files selected for processing (1)
  • README.md (1 hunks)

Comment thread README.md Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@jdegand jdegand merged commit 188a9d9 into PatrickJS:gh-pages Nov 19, 2025
1 check passed
@coderabbitai coderabbitai Bot mentioned this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant