Skip to content

fix(ci): build before release tests#104

Merged
PatrickSys merged 1 commit intomasterfrom
fix/release-publish-build-order-clean
Apr 15, 2026
Merged

fix(ci): build before release tests#104
PatrickSys merged 1 commit intomasterfrom
fix/release-publish-build-order-clean

Conversation

@PatrickSys
Copy link
Copy Markdown
Owner

Summary

  • build before test in the release-please publish job
  • build before test in the manual publish-on-release fallback job
  • preserve the same release-only quality gates while fixing the zombie-guard dist artifact failure

Verification

  • pnpm build
  • pnpm test -- tests/zombie-guard.test.ts

Note: the clean recovery worktree did not have dependencies installed, so the verification above was run in the main repo worktree before the patch was moved onto the correct origin/master base.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 15, 2026

Greptile Summary

This PR fixes the quality gates ordering in both release workflows by moving pnpm build before pnpm test, ensuring the dist/ artifacts exist when tests run. The fix is applied consistently in both release-please.yml and publish-npm-on-release.yml.

Confidence Score: 5/5

Safe to merge — minimal, correct two-line reorder in both release workflows with no functional risk.

Both files contain an identical, targeted swap of two lines. The new order is logically correct and no quality gates are removed or weakened.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/publish-npm-on-release.yml Swaps pnpm test to run after pnpm build in the quality gates step so dist artifacts exist when tests execute.
.github/workflows/release-please.yml Identical reorder of pnpm build before pnpm test in the release-please publish job's quality gates step.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[pnpm install --frozen-lockfile] --> B{Version already\npublished on npm?}
    B -->|yes| Z[Skip quality gates\n& publish]
    B -->|no| C[pnpm lint]
    C --> D[pnpm format:check]
    D --> E[pnpm type-check]
    E --> F[pnpm build\n✅ dist/ artifacts created]
    F --> G[pnpm test\n✅ dist/ artifacts available]
    G --> H[pnpm publish --provenance]
Loading

Reviews (1): Last reviewed commit: "fix(ci): build before release tests" | Re-trigger Greptile

@PatrickSys PatrickSys merged commit 01e8c1b into master Apr 15, 2026
4 checks passed
@PatrickSys PatrickSys deleted the fix/release-publish-build-order-clean branch April 15, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant