Merged
Conversation
Contributor
Greptile SummaryThis PR fixes the quality gates ordering in both release workflows by moving Confidence Score: 5/5Safe to merge — minimal, correct two-line reorder in both release workflows with no functional risk. Both files contain an identical, targeted swap of two lines. The new order is logically correct and no quality gates are removed or weakened. No files require special attention.
|
| Filename | Overview |
|---|---|
| .github/workflows/publish-npm-on-release.yml | Swaps pnpm test to run after pnpm build in the quality gates step so dist artifacts exist when tests execute. |
| .github/workflows/release-please.yml | Identical reorder of pnpm build before pnpm test in the release-please publish job's quality gates step. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[pnpm install --frozen-lockfile] --> B{Version already\npublished on npm?}
B -->|yes| Z[Skip quality gates\n& publish]
B -->|no| C[pnpm lint]
C --> D[pnpm format:check]
D --> E[pnpm type-check]
E --> F[pnpm build\n✅ dist/ artifacts created]
F --> G[pnpm test\n✅ dist/ artifacts available]
G --> H[pnpm publish --provenance]
Reviews (1): Last reviewed commit: "fix(ci): build before release tests" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note: the clean recovery worktree did not have dependencies installed, so the verification above was run in the main repo worktree before the patch was moved onto the correct origin/master base.