chore(git): ignore local benchmark artifacts#118
Conversation
Greptile SummaryThis PR adds ignore rules for local benchmark artifacts, external research clones, bmad agent/vendor artifacts, and Playwright browser-automation outputs, and also removes a duplicate Confidence Score: 4/5Safe to merge; only .gitignore entries are added with no code or functional changes. No P0 or P1 findings. Two P2 style suggestions: No files require special attention.
|
| Filename | Overview |
|---|---|
| .gitignore | Adds ignore rules for benchmark artifacts, research clones, bmad agent artifacts, and Playwright outputs; also removes a duplicate .agents/ entry. Two minor concerns: outputs/ is overly broad, and user-specific paths (skeptical-user) belong in a global gitignore. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Git commit] --> B{Path matches .gitignore?}
B -- No --> C[Tracked normally]
B -- Yes --> D{Which rule?}
D --> E["Benchmark outputs\nbenchmark-runs/, outputs/\nresults/skeptical-user/**"]
D --> F["Research clones\nmatplotlib-repo/\nsympy-contextbench/"]
D --> G["Agent/vendor artifacts\n**/skills/bmad-*/\n_bmad/, _bmad-*/, _bmad-output/"]
D --> H["Browser automation\n.playwright-mcp/"]
E & F & G & H --> I[Excluded from commit]
Reviews (1): Last reviewed commit: "chore(git): ignore local benchmark artif..." | Re-trigger Greptile
|
|
||
| # Local benchmark/lab outputs | ||
| benchmark-runs/ | ||
| outputs/ |
There was a problem hiding this comment.
outputs/ is a very broad top-level ignore
Ignoring outputs/ at the repository root will silently suppress any directory by that name, including legitimate build artifacts or test outputs that a future contributor might intend to track. If only the benchmark-related outputs/ is meant, consider scoping it (e.g. benchmark-runs/outputs/ or a comment-aligned path).
There was a problem hiding this comment.
Addressed in the current diff: outputs/ is now root-anchored as /outputs/, so it only ignores the repo-root generated outputs directory instead of any nested directory named outputs.
| results/skeptical-user/raw/ | ||
| results/skeptical-user/local/ | ||
| results/skeptical-user/tmp/ | ||
| .tmp-skeptical-user/ |
There was a problem hiding this comment.
User-specific paths belong in a global gitignore
results/skeptical-user/, .tmp-skeptical-user/ encode a specific username. Shared .gitignore entries like these add noise for other contributors and are better placed in each developer's ~/.gitignore_global (or git config --global core.excludesFile). The same applies to any path that only makes sense on one person's machine.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Addressed for the results paths: the specific
esults/skeptical-user/... entries were replaced with generalized /results/*/{raw,local,tmp}/ patterns. .tmp-skeptical-user/ is a benchmark-suite temp directory rather than a developer username, and it stays ignored because it is a local generated lab artifact.
Keeps generated benchmark artifacts, external benchmark clones, local agent/vendor artifacts, and browser automation outputs out of future commits. No benchmark results are included or claimed.