Skip to content

chore(git): ignore local benchmark artifacts#118

Merged
PatrickSys merged 2 commits intomasterfrom
pr/git-hygiene
Apr 29, 2026
Merged

chore(git): ignore local benchmark artifacts#118
PatrickSys merged 2 commits intomasterfrom
pr/git-hygiene

Conversation

@PatrickSys
Copy link
Copy Markdown
Owner

Keeps generated benchmark artifacts, external benchmark clones, local agent/vendor artifacts, and browser automation outputs out of future commits. No benchmark results are included or claimed.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 29, 2026

Greptile Summary

This PR adds ignore rules for local benchmark artifacts, external research clones, bmad agent/vendor artifacts, and Playwright browser-automation outputs, and also removes a duplicate .agents/ entry from .gitignore. The changes are purely additive gitignore configuration with no functional code impact.

Confidence Score: 4/5

Safe to merge; only .gitignore entries are added with no code or functional changes.

No P0 or P1 findings. Two P2 style suggestions: outputs/ is broader than needed and could mask future tracked directories, and user-specific path fragments (skeptical-user) are better kept in a global gitignore. Neither blocks merging.

No files require special attention.

Important Files Changed

Filename Overview
.gitignore Adds ignore rules for benchmark artifacts, research clones, bmad agent artifacts, and Playwright outputs; also removes a duplicate .agents/ entry. Two minor concerns: outputs/ is overly broad, and user-specific paths (skeptical-user) belong in a global gitignore.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Git commit] --> B{Path matches .gitignore?}
    B -- No --> C[Tracked normally]
    B -- Yes --> D{Which rule?}
    D --> E["Benchmark outputs\nbenchmark-runs/, outputs/\nresults/skeptical-user/**"]
    D --> F["Research clones\nmatplotlib-repo/\nsympy-contextbench/"]
    D --> G["Agent/vendor artifacts\n**/skills/bmad-*/\n_bmad/, _bmad-*/, _bmad-output/"]
    D --> H["Browser automation\n.playwright-mcp/"]
    E & F & G & H --> I[Excluded from commit]
Loading

Reviews (1): Last reviewed commit: "chore(git): ignore local benchmark artif..." | Re-trigger Greptile

Comment thread .gitignore Outdated

# Local benchmark/lab outputs
benchmark-runs/
outputs/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 outputs/ is a very broad top-level ignore

Ignoring outputs/ at the repository root will silently suppress any directory by that name, including legitimate build artifacts or test outputs that a future contributor might intend to track. If only the benchmark-related outputs/ is meant, consider scoping it (e.g. benchmark-runs/outputs/ or a comment-aligned path).

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in the current diff: outputs/ is now root-anchored as /outputs/, so it only ignores the repo-root generated outputs directory instead of any nested directory named outputs.

Comment thread .gitignore Outdated
Comment on lines +38 to +41
results/skeptical-user/raw/
results/skeptical-user/local/
results/skeptical-user/tmp/
.tmp-skeptical-user/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 User-specific paths belong in a global gitignore

results/skeptical-user/, .tmp-skeptical-user/ encode a specific username. Shared .gitignore entries like these add noise for other contributors and are better placed in each developer's ~/.gitignore_global (or git config --global core.excludesFile). The same applies to any path that only makes sense on one person's machine.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed for the results paths: the specific
esults/skeptical-user/... entries were replaced with generalized /results/*/{raw,local,tmp}/ patterns. .tmp-skeptical-user/ is a benchmark-suite temp directory rather than a developer username, and it stays ignored because it is a local generated lab artifact.

@PatrickSys PatrickSys merged commit 40e3afc into master Apr 29, 2026
3 checks passed
@PatrickSys PatrickSys deleted the pr/git-hygiene branch April 30, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant