fix: resolve installer stall and add clear completion signal#91
Merged
PatrickSys merged 2 commits intomainfrom Apr 24, 2026
Merged
fix: resolve installer stall and add clear completion signal#91PatrickSys merged 2 commits intomainfrom
PatrickSys merged 2 commits intomainfrom
Conversation
After the last wizard prompt, Node's event loop stayed alive because promptChoiceList resumed stdin via emitKeypressEvents but never paused it in cleanup(). The process appeared hung even though all output had been written. Users had to force-quit before reading the completion text. - pause stdin in promptChoiceList cleanup so the event loop can drain - add process.exit() under IS_MAIN as a hard backstop against future leaks - upgrade completion banner to bold green ✓ and add an explicit "Setup complete — this session will now exit." line so users know the wizard finished intentionally
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b90644ecf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
process.exit() can truncate buffered stdout/stderr in piped or redirected usage before streams fully flush. The stdin.pause() in promptChoiceList cleanup already lets the event loop drain naturally; the forced exit was unnecessary backstop that introduced data-loss risk.
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 24, 2026
# [0.19.0](v0.18.5...v0.19.0) (2026-04-24) ### Bug Fixes * accept successful npm token exchange responses ([e58847f](e58847f)) * fail fast without npm trusted publishing ([e3b3578](e3b3578)) * resolve installer stall and add clear completion signal ([#91](#91)) ([017620f](017620f)) ### Features * add brownfield change continuity flow ([2915854](2915854))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gsdd initstalled after the last wizard prompt becausepromptChoiceListresumed stdin viareadline.emitKeypressEventsbut never paused it incleanup()— the Node event loop stayed alive with stdin open, so the process appeared hung even though all output had already been writtenCtrl+C) before they could read the routing instructions, making the installer feel brokenChanges
bin/lib/init-prompts.mjs— addinput.pause()topromptChoiceList'scleanup()so stdin is released after each choice-list prompt; lets the event loop drain naturally once the wizard finishesbin/gsdd.mjs— addprocess.exit(process.exitCode ?? 0)under theIS_MAINguard as a hard backstop against any future open-handle leakbin/lib/init-flow.mjs— upgrade the completion banner to a bold green✓ GSDD initialized.and appendSetup complete — this session will now exit.so users see an unambiguous signal that the wizard finished intentionallyTest plan
node bin/gsdd.mjs initinteractively in a scratch dir; confirm the shell prompt returns automatically after the last wizard step (no Ctrl+C needed)node bin/gsdd.mjs init --auto --tools claudein a scratch dir; confirm clean non-interactive exitnode bin/gsdd.mjs helpandnode bin/gsdd.mjs health; confirm both exit with code 0node bin/gsdd.mjs bogus-cmd; echo $?; confirm exit code 1