Skip to content

Fix inject #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thet merged 2 commits into from
Feb 3, 2025
Merged

Fix inject #1235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3718361
fix(pat-inject): Fix error when no title is found.
thet Feb 3, 2025
6c9ad2d
maint(pat-inject): Minor code optimization.
thet Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pat/inject/inject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,13 +498,13 @@ const inject = {
return;
}
let url = cfg.url;
const glue = url.indexOf("?") > -1 ? "&" : "?";
if (cfg.params) {
const glue = url.indexOf("?") > -1 ? "&" : "?";
url = `${url}${glue}${cfg.params}`;
}
history.pushState({ url: url }, "", url);
// Also inject title element if we have one
if ($title.length) {
if ($title?.length) {
const title_el = document.querySelector("title");
if (title_el) {
this._inject(trigger, $title, title_el, {
Expand Down
78 changes: 78 additions & 0 deletions src/pat/inject/inject.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1739,6 +1739,84 @@ describe("pat-inject", function () {
expect(title).toBeTruthy();
expect(title.textContent.trim()).toBe("test"); // Old title
});

it("9.4.3 - Does not break, if no title is found in source", async function () {
document.head.innerHTML = `
<title>test</title>
`;
document.body.innerHTML = `
<a class="pat-inject"
href="test.html"
data-pat-inject="
source: body;
target: body;
history: record;
">link</a>
`;

answer(`
<html>
<body>
OK
</body>
</html>
`);

const inject = document.querySelector(".pat-inject");

pattern.init($(inject));
await utils.timeout(1); // wait a tick for async to settle.

inject.click();

await utils.timeout(1); // wait a tick for async to settle.

expect(document.body.textContent.trim()).toBe("OK");

// Title in head target is not modified.
const title = document.head.querySelector("title");
expect(title).toBeTruthy();
expect(title.textContent.trim()).toBe("test"); // Old title
});

it("9.4.4 - Does not break, if no title is found in target", async function () {
document.head.innerHTML = "";
document.body.innerHTML = `
<a class="pat-inject"
href="test.html"
data-pat-inject="
source: body;
target: body;
history: record;
">link</a>
`;

answer(`
<html>
<head>
<title>hello</title>
<body>
OK
</body>
</html>
`);

const inject = document.querySelector(".pat-inject");

pattern.init($(inject));
await utils.timeout(1); // wait a tick for async to settle.

inject.click();

await utils.timeout(1); // wait a tick for async to settle.

expect(document.body.textContent.trim()).toBe("OK");

// There is no title to be updated in target.
const title = document.head.querySelector("title");
expect(title).toBeFalsy();
});

});

describe("9.5 - support multiple source element matches.", function () {
Expand Down