Skip to content

ep-admin DX: harden --json failure contract and fix swallowed errors#262

Merged
PaulJPhilp merged 1 commit into
mainfrom
codex/ep-admin-json-contract-hardening
Feb 15, 2026
Merged

ep-admin DX: harden --json failure contract and fix swallowed errors#262
PaulJPhilp merged 1 commit into
mainfrom
codex/ep-admin-json-contract-hardening

Conversation

@PaulJPhilp
Copy link
Copy Markdown
Owner

Summary

  • harden ep-admin machine-mode contract so --json commands do not emit stdout payloads on failures
  • fix swallowed failures that previously returned exit code 0 in error paths
  • prevent non-JSON progress lines from leaking to stdout in config install skills --json
  • extend CLI contract tests for deterministic JSON-failure cases

Changes

  • packages/ep-admin/src/search-commands.ts
    • fix catchAll to re-fail correctly (yield* Effect.fail) so DB errors return non-zero exit
  • packages/ep-admin/src/lock-commands.ts
    • fix catchAll to re-fail correctly (yield* Effect.fail)
  • packages/ep-admin/src/install-commands.ts
    • remove JSON payload writes in failure branches (install add + install skills) so failure mode keeps stdout empty
    • gate category loop progress logs behind non-JSON logging helper to keep stdout parse-clean in JSON mode
  • packages/ep-admin/src/__tests__/cli-json-contract.test.ts
    • add assertions for deterministic validation failures:
      • config install add --tool badtool --json
      • config install skills --format invalid --json
    • add failure assertion for pattern search ... --json under forced bad DATABASE_URL

Verification

  • cd packages/ep-admin && bunx vitest run src/__tests__/cli-json-contract.test.ts
  • cd packages/ep-admin && bunx vitest run src/__tests__/cli-auth-contract.test.ts
  • cd packages/ep-admin && bunx vitest run src/__tests__/completions.test.ts
  • cd packages/ep-admin && bunx vitest run src/__tests__

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
effect-patterns Ignored Ignored Feb 15, 2026 10:43pm
effect-patterns-mcp-server Ignored Ignored Feb 15, 2026 10:43pm
effect-patterns-mcp-tier-v2 Ignored Ignored Feb 15, 2026 10:43pm

Request Review

@github-actions
Copy link
Copy Markdown

🔒 Security Scan Summary

Status: ✅ All checks passed

Check Result
Dependency Audit success
Secret Scan success
License Check success

View detailed results

@PaulJPhilp PaulJPhilp merged commit d6586ec into main Feb 15, 2026
23 checks passed
@PaulJPhilp PaulJPhilp deleted the codex/ep-admin-json-contract-hardening branch February 15, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant