Only extract leaflet events for prop keys when callback exists#308
Merged
PaulLeCam merged 1 commit intoPaulLeCam:masterfrom Apr 5, 2017
Merged
Only extract leaflet events for prop keys when callback exists#308PaulLeCam merged 1 commit intoPaulLeCam:masterfrom
PaulLeCam merged 1 commit intoPaulLeCam:masterfrom
Conversation
Fixes the following: <MapComponent onClick={null} />
awinograd
commented
Apr 4, 2017
| if (EVENTS_RE.test(prop)) { | ||
| const key = prop.replace(EVENTS_RE, (match, p) => p.toLowerCase()) | ||
| res[ key ] = props[ prop ] | ||
| if (props[ prop ]) { |
Contributor
Author
There was a problem hiding this comment.
another option would be to do:
if (typeof props[ prop ] === 'function')
Contributor
Author
|
The CI seems to be failing for non PR related reasons |
Owner
|
Good idea, thanks! |
Contributor
Author
|
Thanks @PaulLeCam! Hope it's helpful to others as well |
Owner
|
Yes, it's always a nice feature to have! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following when
myConditionisfalsey.<MapComponent onClick={myCondition ? myCallback : null} />