Feat/invoice pdf #1014

lissavxo · 2025-06-18T19:00:09Z

Related to #528

Depends on

Feat/invoice #1007

Description

Added download pdf function in view invoice modal.

Test plan

Go to a transaction in button details, create an invoice, click view invoice>Download as PDF

Klakurka

This should be part of the Payments page, not the Transactions table. The transactions table in the button details isn't really a place we want people having to go to often unless they're really curious about what's going on in their wallets.
On the 'Amount' field in the Create Invoice dialog, let's include the currency icon somewhere so it's clear what units it uses.
Maybe add a slight 'greyed out' style to the inputs that are read-only? @johnkuney can suggest.
If the user has an org set, auto-fill 'Customer Name' field with the org name.

Klakurka · 2025-06-19T23:54:28Z

components/Transaction/PaybuttonTransactions.tsx

                    <button
-                      onClick={() => onSeeInvoice(cellProps.row.original.invoices[0])}
+                      onClick={() => onSeeInvoice(invoice)}
                      title="See Invoice"


Change to 'View Invoice'.

Klakurka · 2025-06-19T23:54:55Z

components/Transaction/PaybuttonTransactions.tsx

                  <div className={style.see_invoice_ctn}>
                    <button
-                      onClick={() => onSeeInvoice(cellProps.row.original.invoices[0])}
+                      onClick={() => onSeeInvoice(invoice)}


Change onSeeInvoice to onViewInvoice (more standard language).

chedieck

This magic number indexing of invoices from a tx (transaction.invoices[0]) is very unsafe. Right now if two users add the same address to one of their buttons, and one of them creates an invoice for one of the address' txs, the other will be able to see that invoice.

chedieck · 2025-06-19T23:59:07Z

components/Transaction/Invoice.tsx

+    minute: '2-digit',
+    hour12: true
+  }).replace(',', '')
+  const url = transactionNetworkId === 1 ? XEC_TX_EXPLORER_URL : BCH_TX_EXPLORER_URL


Shouldn't use a magic number here, we have XEC_NETWORK_ID in constants/index

chedieck · 2025-06-20T00:46:13Z

components/Transaction/PaybuttonTransactions.tsx

+              transactionHash: transaction.hash,
+              transactionDate: transaction.timestamp,
+              transactionNetworkId: transaction.address.networkId,
+              ...transaction.invoices[0]


johnkuney · 2025-06-23T02:51:57Z

Im getting this error if I try to view a button details page on this branch. Master seems to work fine for me...not sure what the issue is

lissavxo · 2025-06-23T16:57:22Z

This magic number indexing of invoices from a tx (transaction.invoices[0]) is very unsafe. Right now if two users add the same address to one of their buttons, and one of them creates an invoice for one of the address' txs, the other will be able to see that invoice.

we are fetching the transactions filtering by the userId, so that wont happen

lissavxo · 2025-06-25T23:05:50Z

This magic number indexing of invoices from a tx (transaction.invoices[0]) is very unsafe. Right now if two users add the same address to one of their buttons, and one of them creates an invoice for one of the address' txs, the other will be able to see that invoice.

Added verification to only return invoices from the user that is requesting

Klakurka

Being able to sort the 'Actions' column doesn't make any sense and also throws an error.
We need to figure out a more clear way for people to know what the buttons do as it is not at all obvious without hovering and the tooltip takes a second to appear. We could possibly change 'Actions' to 'Invoice' in the table header.

Copilot

Pull Request Overview

Adds invoice support and PDF download functionality to the payments UI and backend services.

Extends transaction queries and cache generation to include invoice data
Defines new Redis types for invoices and updates payment transformation functions
Implements create/edit/view invoice modal with "Download as PDF" feature on the Payments page

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
services/transactionService.ts	Includes invoices in raw SQL query and adds JSON parsing
services/invoiceService.ts	Adds null-check for missing invoice in update flow
redis/types.ts	Defines `InvoiceData` and extends `Payment` interface
redis/paymentCache.ts	Implements `generatePaymentFromTxWithInvoices`
pages/payments/index.tsx	Adds invoice modal handlers, props and table action column
components/Transaction/InvoiceModal.tsx	Integrates `react-to-print` and hidden printable receipt

Comments suppressed due to low confidence (1)

pages/payments/index.tsx:67

The organization prop can be null when no organization is found. Update the type to Organization | null to reflect that possibility and avoid runtime errors.

  organization: Organization

pages/payments/index.tsx

services/transactionService.ts

components/Transaction/InvoiceModal.tsx

pages/payments/payments.module.css

chedieck · 2025-07-15T18:05:50Z

redis/types.ts

  providerUserId?: string
 }

+export interface InvoiceData {


Why is this needed if is not used in the cache? Why not use just Prisma.Invoice?

Removed InvoiceData and created prisma type for InvoiceWithTransaction

Klakurka

Minor nit but let's move the dialog buttons around a bit:

Change 'Close' to 'Cancel' to match the other buttons.
Move the 'Cancel' button to the left.
Have the Download PDF button be on the right.

For reference:

Have the 'Cancel' button be the darker button. All of them should be like this throughout the site - not sure why some aren't.

Klakurka

Forgot to mention - the submit (for creation) button should use the same loading spinner as throughout the rest of the site.

Klakurka requested review from Klakurka and chedieck June 19, 2025 21:18

lissavxo force-pushed the feat/invoice-pdf branch from c624727 to 7c6bf45 Compare June 19, 2025 21:29

Klakurka requested changes Jun 19, 2025

View reviewed changes

chedieck requested changes Jun 20, 2025

View reviewed changes

lissavxo added 3 commits June 25, 2025 19:21

feat: invoice pdf

43a38c8

feat: move invoices to payments page

29f256b

feat: remove idor invoices

5f4b327

lissavxo force-pushed the feat/invoice-pdf branch from 7c6bf45 to 5f4b327 Compare June 25, 2025 23:04

lissavxo requested review from Klakurka and chedieck June 25, 2025 23:05

feat: add generatePaymentFromTxWithInvoices method

15ccc3f

lissavxo force-pushed the feat/invoice-pdf branch from e38de15 to 15ccc3f Compare June 26, 2025 19:23

lissavxo mentioned this pull request Jul 3, 2025

Feat/year payments filter #1017

Merged

1 task

Klakurka requested changes Jul 5, 2025

View reviewed changes

Klakurka requested a review from Copilot July 7, 2025 05:01

Klakurka assigned lissavxo Jul 7, 2025

This comment was marked as outdated.

Sign in to view

refactor: copilot suggestions

6a12b06

lissavxo requested review from Klakurka and Copilot July 8, 2025 15:05

Copilot AI reviewed Jul 8, 2025

View reviewed changes

chedieck requested changes Jul 15, 2025

View reviewed changes

lissavxo added 2 commits July 16, 2025 11:18

refactor: use prisma type invoice

106cc9b

refactor: fix invoiceWithTransaction type

27a0413

chedieck previously approved these changes Jul 17, 2025

View reviewed changes

Klakurka requested changes Jul 21, 2025

View reviewed changes

fix: cancel buttons color

a8fecb1

lissavxo dismissed chedieck’s stale review via a8fecb1 July 25, 2025 17:11

lissavxo requested a review from Klakurka July 25, 2025 17:11

Klakurka requested changes Jul 26, 2025

View reviewed changes

This comment was marked as duplicate.

Sign in to view

fix:loading submit invoices

bc547ff

lissavxo requested review from Klakurka and chedieck July 31, 2025 20:59

Klakurka approved these changes Jul 31, 2025

View reviewed changes

Klakurka merged commit 1557a44 into master Aug 1, 2025
2 checks passed

Feat/invoice pdf #1014

Feat/invoice pdf #1014

Uh oh!

Conversation

lissavxo commented Jun 18, 2025 • edited by Klakurka Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Depends on

Description

Test plan

Uh oh!

Klakurka left a comment

Choose a reason for hiding this comment

Uh oh!

Klakurka Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

Klakurka Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

chedieck left a comment

Choose a reason for hiding this comment

Uh oh!

chedieck Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

chedieck Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

johnkuney commented Jun 23, 2025

Uh oh!

lissavxo commented Jun 23, 2025

Uh oh!

lissavxo commented Jun 25, 2025

Uh oh!

Klakurka left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chedieck Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

lissavxo Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Klakurka left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Klakurka left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as duplicate.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lissavxo commented Jun 18, 2025 •

edited by Klakurka

Loading

Klakurka left a comment •

edited

Loading

Klakurka left a comment •

edited

Loading