-
Notifications
You must be signed in to change notification settings - Fork 3
Added vertical scrollbar to addresses list #1077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a vertical scrollbar to the addresses list on the button detail page to improve usability when buttons have many addresses.
Key Changes:
- Added a wrapper div with scrolling styles around the addresses list
- Implemented a CSS class with max-height and vertical scrolling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| components/Paybutton/paybutton-detail.module.css | Added CSS class with max-height of 500px and vertical auto-overflow |
| components/Paybutton/PaybuttonDetail.tsx | Wrapped the addresses list with a div applying the new scrollable container class |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
WalkthroughThe PayButton component's address display interface has been refactored. The copy button functionality is relocated from a standalone block to become inline within each individual address item. A container wrapper is introduced around the address list alongside new CSS styling for scrollable content. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/Paybutton/paybutton-detail.module.css (1)
87-90: Consider responsive design for smaller screens.The fixed
max-height: 500pxworks for desktop, but may consume excessive vertical space on mobile devices. Consider using viewport-relative units or media queries to adjust the height for smaller screens.Apply this diff to add responsive behavior:
.paybutton_detail_address { - max-height: 500px; + max-height: min(500px, 50vh); overflow-y: auto; }Alternatively, use media queries for more granular control:
.paybutton_detail_address { max-height: 500px; overflow-y: auto; } @media (max-width: 960px) { .paybutton_detail_address { max-height: 300px; } }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
components/Paybutton/PaybuttonDetail.tsx(1 hunks)components/Paybutton/paybutton-detail.module.css(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Run Tests
🔇 Additional comments (1)
components/Paybutton/PaybuttonDetail.tsx (1)
59-84: Implementation looks good, achieves the PR objective.The scrollable container is correctly implemented and the copy button is now properly integrated inline within each address item. The event handling with
stopPropagationandpreventDefaultensures the click doesn't trigger parent handlers.Consider verifying keyboard accessibility: users navigating via keyboard should be able to scroll through the address list. Test with Tab/Shift+Tab navigation and ensure the scrollable area is accessible.
Related to #1074
Description
Adds scrollbar on /button/xxx page for buttons that have a lot of addresses
Test plan
Visit a /button/xxx page for a button with lots of addresses and see the scrollbar in action. The page is a bit more manageable with this change
Summary by CodeRabbit
Release Notes