[#655, #713]UI: footer button and logo sizing #719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klakurka
reviewed
Oct 16, 2023
Member
Klakurka
left a comment
Klakurka
left a comment
There was a problem hiding this comment.
The logo size is the same now but position is slightly off -- do you think it's better to just leave it like that or adjust the alignment on the landing page to match?
Collaborator
Author
|
ah yeah sure, I adjusted so the heights will match. Unfortunately theres not a great way to ensure the horizontal positions are always the same if you are a large screen, since the dashboard has no fixed width, the logo can be farther to the left. Can adjust any of those pieces if needed though of course depending what feels best for larger screens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #655 #713
Description
Fixing the issue of the sign up button not showing in the footer, and also matching the new behavior of the navbar so dashboard and Sign out show in the footer when logged in. Also sniped the logo size to match in the navbar, footer, and dashboard views
Test plan
Run the app and check the footer links look good when logged in and not logged in