Feat/preferred quote csv #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klakurka
approved these changes
Sep 25, 2024
Member
Klakurka
left a comment
Klakurka
left a comment
There was a problem hiding this comment.
It requires a refresh which is not a huge deal but maybe we can have it apply instantly to the page in a future update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #848
Description
Added currency filter and implemented preferredCurrency filter in the export csv logic
Test plan
Run the project with
docker compose upgo to button page and export CSV, check if currency is USDChange the
preferredCurrencyIdinUserProfiletable and check if the Value column in CSV is the one you set