Skip to content

Fix/csv download default currency #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Klakurka merged 2 commits into from
Oct 2, 2024
Merged

Fix/csv download default currency #873

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc1b203
fix: CSV default currency
chedieck Oct 1, 2024
10417c9
Merge branch 'master' into fix/csv-download-default-currency
chedieck Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pages/api/paybutton/download/transactions/[paybuttonId].ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import {
NetworkTickersType,
NETWORK_TICKERS,
NETWORK_IDS,
SUPPORTED_QUOTES_FROM_ID
SUPPORTED_QUOTES_FROM_ID,
USD_QUOTE_ID
} from 'constants/index'
import { TransactionWithAddressAndPrices, fetchTransactionsByPaybuttonId, getTransactionValueInCurrency } from 'services/transactionService'
import { PaybuttonWithAddresses, fetchPaybuttonById } from 'services/paybuttonService'
Expand Down Expand Up @@ -147,7 +148,12 @@ export default async (req: any, res: any): Promise<void> => {
const networkTickerReq = req.query.network as string

const networkTicker = (networkTickerReq !== '' && isNetworkValid(networkTickerReq as NetworkTickersType)) ? networkTickerReq.toUpperCase() as NetworkTickersType : undefined
const quoteId = req.query.currency as number
let quoteId: number
if (req.query.currency === undefined || req.query.currency === '' || Number.isNaN(req.query.currency)) {
quoteId = USD_QUOTE_ID
} else {
quoteId = req.query.currency as number
}
const quoteSlug = SUPPORTED_QUOTES_FROM_ID[quoteId]
const paybutton = await fetchPaybuttonById(paybuttonId)
if (paybutton.providerUserId !== userId) {
Expand Down