[UI] Add advanced button generator options #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klakurka
requested changes
Nov 19, 2024
Member
Klakurka
left a comment
Klakurka
left a comment
There was a problem hiding this comment.
- Nit but when you toggle the "disable payment id" option on/off, we're inconsistent with the other toggles where we normally just remove it from the div so they're not copying extra stuff they don't need.
Collaborator
Author
|
Ah yeah good catch, added |
Klakurka
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #794 & #804
Description
Adding op return and disable payment id to the button generator
Also sneaking in a CSS tweak to prevent the wallet dialog from running off the page
Test plan
Check the button generator and check the create or edit wallet dialog in an account with lots of buttons