fix: negative indexes #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klakurka
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #
Description
Fixes bug where many payments from last year wouldn't appear in the dashboard.
Test plan
Make sure that now the dashboard plots show # of payments & their revenue as expected.
Remarks
Technical explanation:
I assumed that the remainder operator in JS worked just like in Python, where the sign of the result is always the same as the sign of the divisor. In truth, the sign of the remainder division result in JS is equal to the dividend's, not the divisor's. To clarify:
... so this solves the issue by adding the divisor to the dividend, which will make it positive if it's negative (since it's never less than minus the divisor) or will have no effect if it is already positive.