Skip to content

Conversation

@xecdev
Copy link
Collaborator

@xecdev xecdev commented Mar 16, 2025

This PR implements issue #1 by adding native support for a PayButton generator. The new generator is a streamlined version of the Button Generator found on PayButton.org. With this enhancement, WordPress administrators can easily create simple buttons (for donations, "buy me a coffee", etc.) and embed them into posts or pages using a shortcode.

Test plan:

  • Install the plugin
  • Go to the Button Generator page (either from the menu or from the PayButton Dashboard)
  • If the styling of the Button Generator page seems off, then clear the cache by hard-refreshing the page (WP caches CSS for admin pages)
  • Generate a button
  • Check the form's functionalities (Tooltips, dropdowns...)
  • Copy-paste the generated shortcode to a post or page and verify that it works

@xecdev xecdev added the enhancement (UI/UX/feature) New feature or request label Mar 16, 2025
@xecdev xecdev requested a review from Klakurka March 16, 2025 13:07
@xecdev xecdev self-assigned this Mar 16, 2025
Copy link
Member

@Klakurka Klakurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When attempting to update the previously-installed plugin, it doesn't seem to do it and instead just installs the new one along side it so that it shows a Warning: Constant PAYBUTTON_PLUGIN_DIR already defined in C:\Users\david\Local Sites\paybutton\app\public\wp-content\plugins\wordpress-plugin-fix-improve-unlocked-content-indicator-style\paybutton.php on line 24 at the top of the Paywall Settings page and every page appears twice for me. Removing both and installing again fixed it.
  • When switching to a BCH address, the primary colour should change to #4BC846. When going from BCH -> XEC, it should also change back the primary colour to 4BC846.
  • Would be nice to have a copy button next to the 'shortcode'.

@xecdev xecdev requested a review from Klakurka March 17, 2025 11:04
@xecdev
Copy link
Collaborator Author

xecdev commented Mar 17, 2025

Fixed. Please review it again.

Copy link
Member

@Klakurka Klakurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Click-to-copy doesn't work for me. It should both copy to clipboard and also display a 'Copied!' text instead of 'Click to copy!' when clicked.
  • Editing the primary colour no longer works.

@xecdev xecdev requested a review from Klakurka March 18, 2025 08:45
@Klakurka Klakurka merged commit ae01638 into master Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement (UI/UX/feature) New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants