Skip to content

fix: update latest version and dashboard max in upgrade policy#39

Merged
aryaman-payram merged 1 commit into
mainfrom
develop
Apr 8, 2026
Merged

fix: update latest version and dashboard max in upgrade policy#39
aryaman-payram merged 1 commit into
mainfrom
develop

Conversation

@aryaman-payram
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 8, 2026

Summary by CodeRabbit

  • Chores
    • Updated upgrade policy configuration to recognize versions 1.9.4, 1.9.5, and 1.9.6 in the release registry.
    • Advanced latest and dashboard version targets to 1.9.5.
    • Advanced updater API initialization version to 1.9.6.

Walkthrough

The upgrade policy configuration is updated to advance version targets from 1.9.3 to 1.9.5 for latest and dashboard deployments, 1.9.6 for the updater API initialization, and the releases array is extended to include versions 1.9.5 and 1.9.4.

Changes

Cohort / File(s) Summary
Upgrade Policy Configuration
updater-configs/upgrade-policy.json
Version targets advanced: latest and dashboard_max bumped to 1.9.5, updater_api_init_version bumped to 1.9.6. Releases array expanded to include 1.9.5 and 1.9.4 entries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • sam6230i
  • iam-joey

Poem

🐰 Version bumps hop along with glee,
1.9.5 and 1.9.4, now we can see!
The updater reaches 1.9.6 high,
New releases soar across the sky! 🚀

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining the purpose of these version updates and any related context or issues.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating version numbers in the upgrade policy configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@updater-configs/upgrade-policy.json`:
- Line 4: The value of updater_api_init_version ("updater_api_init_version") is
set to a non-existent release (1.9.6) and must be reconciled with the releases
list; either change updater_api_init_version to an actual released version
(e.g., "1.9.5") or add "1.9.6" to the releases array so they match—update the
JSON accordingly and ensure the string value exactly matches an entry in
"releases".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 42f947b5-4edc-4afd-8392-bf55243fd84c

📥 Commits

Reviewing files that changed from the base of the PR and between b79bdae and c78b7d2.

📒 Files selected for processing (1)
  • updater-configs/upgrade-policy.json

"updater_api_init_version": "1.9.3",
"dashboard_max": "1.9.3",
"latest": "1.9.5",
"updater_api_init_version": "1.9.6",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify whether updater_api_init_version is required to exist in releases
# and whether current config violates that invariant.

set -euo pipefail

CONFIG_FILE="$(fd -t f upgrade-policy.json | head -n 1)"

python - <<'PY'
import json, sys, pathlib

p = pathlib.Path("""'"$CONFIG_FILE"'""")
data = json.loads(p.read_text())

init_v = data.get("updater_api_init_version")
releases = data.get("releases", [])

print(f"config: {p}")
print(f"updater_api_init_version: {init_v}")
print(f"top_release: {releases[0] if releases else None}")
print(f"is_init_in_releases: {init_v in releases}")

if init_v not in releases:
    print("WARNING: init version is not in releases list")
PY

# Optional: find code paths that enforce membership checks or semver gates.
rg -n -C3 'updater_api_init_version|releases|upgrade-policy|semver|version'

Repository: PayRam/payram-scripts

Length of output: 609


🏁 Script executed:

#!/bin/bash
# First, locate and examine the upgrade-policy.json file
echo "=== Finding upgrade-policy.json ==="
find . -name "upgrade-policy.json" -type f

echo -e "\n=== Content of upgrade-policy.json ==="
if [ -f "updater-configs/upgrade-policy.json" ]; then
  cat -n "updater-configs/upgrade-policy.json"
else
  echo "File not found at expected path"
fi

Repository: PayRam/payram-scripts

Length of output: 1243


🏁 Script executed:

#!/bin/bash
# Search for any code/documentation that validates updater_api_init_version
echo "=== Searching for version validation logic ==="
rg -n "updater_api_init_version" --type json --type py --type js --type ts -A 2 -B 2

echo -e "\n=== Searching for version comparison/validation logic ==="
rg -n "releases|version.*check|version.*valid" -t json -t py -t js -t ts | head -30

Repository: PayRam/payram-scripts

Length of output: 546


🏁 Script executed:

#!/bin/bash
# Search for any references to upgrade-policy.json or its fields in source code
echo "=== Files that reference upgrade-policy or config ==="
rg -n "upgrade-policy|updater_api_init_version|dashboard_max" --type-list | grep -o "^[a-z]*" | sort -u

echo -e "\n=== Searching across all file types ==="
rg -l "upgrade.policy|updater_api_init" 

echo -e "\n=== Any Python/Node code that loads JSON configs ==="
rg -n "json.load|JSON.parse" -B 2 -A 2 | head -50

echo -e "\n=== Directory structure of updater-configs ==="
ls -la updater-configs/ 2>/dev/null || echo "Directory listing not available"

Repository: PayRam/payram-scripts

Length of output: 3376


🏁 Script executed:

#!/bin/bash
# Look for any test files or documentation that explain the version policy
echo "=== Search for README or docs ==="
find . -maxdepth 2 -name "README*" -o -name "*.md" | head -10 | xargs grep -l "version\|upgrade" 2>/dev/null || echo "No relevant docs found"

echo -e "\n=== Search for any Python/Node scripts that might validate this ==="
find . -name "*.py" -o -name "*.js" -o -name "*.ts" | xargs grep -l "updater_api_init_version\|upgrade.policy" 2>/dev/null | head -10

Repository: PayRam/payram-scripts

Length of output: 207


🏁 Script executed:

#!/bin/bash
# Check the README files for information about version policy
echo "=== README.md mentions of version/upgrade ==="
grep -n -i "version\|upgrade\|updater" README.md | head -20

echo -e "\n=== IMPLEMENTATION_SUMMARY.md mentions of version/upgrade ==="
grep -n -i "version\|upgrade\|updater" IMPLEMENTATION_SUMMARY.md | head -20

echo -e "\n=== Check for any CI/CD or deployment scripts ==="
find . -name "*.sh" -type f | head -10 | xargs grep -l "upgrade-policy" 2>/dev/null || echo "No shell scripts found"

echo -e "\n=== Check runtime-manifest.json for clues ==="
cat updater-configs/runtime-manifest.json

Repository: PayRam/payram-scripts

Length of output: 776


updater_api_init_version is ahead of available releases and should be corrected.

"updater_api_init_version": "1.9.6" exceeds the highest released version (1.9.5) and does not exist in the releases list. This creates a configuration inconsistency that external updater clients will encounter. Align this with an actual released version or add 1.9.6 to the releases list if intentional.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@updater-configs/upgrade-policy.json` at line 4, The value of
updater_api_init_version ("updater_api_init_version") is set to a non-existent
release (1.9.6) and must be reconciled with the releases list; either change
updater_api_init_version to an actual released version (e.g., "1.9.5") or add
"1.9.6" to the releases array so they match—update the JSON accordingly and
ensure the string value exactly matches an entry in "releases".

@aryaman-payram aryaman-payram merged commit 00e30f8 into main Apr 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants