-
Notifications
You must be signed in to change notification settings - Fork 99
feat: verifiedAddresses in public API interface #635
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,8 @@ | ||
| /* eslint-disable import/no-cycle -- | ||
| Cycle between this file and types/verifiedAddress.ts. Should we combine these into one? | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Currently we have a types file for verified addresses, and one for the public API. The other two type files are database types. I'm thinking that the verified addresses types, and public api types, are really all just protocol types. I'm thinking we should combine these into one file like ( What do you think?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ya I'm into that, these have been calling for a refactor for a minute now |
||
| */ | ||
| import { VerifiedAddress } from './verifiedAddress' | ||
|
|
||
| /** | ||
| * Type of payment address in PaymentInformation. | ||
| */ | ||
|
|
@@ -27,8 +32,9 @@ export interface FiatAddressDetails { | |
| * case of a GET request to the base path /). | ||
| */ | ||
| export interface PaymentInformation { | ||
| readonly addresses: Address[] | ||
| readonly payId?: string | ||
| readonly addresses: Address[] | ||
| readonly verifiedAddresses: VerifiedAddress[] | ||
| readonly memo?: string | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,6 +31,7 @@ describe('E2E - publicAPIRouter - Base PayID', function (): void { | |
| }, | ||
| }, | ||
| ], | ||
| verifiedAddresses: [], | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updates a bunch of tests so they continue to pass. |
||
| payId: 'alice$127.0.0.1', | ||
| } | ||
|
|
||
|
|
@@ -62,6 +63,7 @@ describe('E2E - publicAPIRouter - Base PayID', function (): void { | |
| }, | ||
| }, | ||
| ], | ||
| verifiedAddresses: [], | ||
| payId: 'alice$127.0.0.1', | ||
| } | ||
|
|
||
|
|
@@ -93,6 +95,7 @@ describe('E2E - publicAPIRouter - Base PayID', function (): void { | |
| }, | ||
| }, | ||
| ], | ||
| verifiedAddresses: [], | ||
| payId: 'alice$127.0.0.1', | ||
| } | ||
|
|
||
|
|
@@ -124,6 +127,7 @@ describe('E2E - publicAPIRouter - Base PayID', function (): void { | |
| }, | ||
| }, | ||
| ], | ||
| verifiedAddresses: [], | ||
| payId: 'alice$127.0.0.1', | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, this will just be an empty response.