This repository was archived by the owner on Mar 8, 2024. It is now read-only.
feat: make fiat change non-breaking #639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Updates public API response to intelligently decide on
ACHvs.FIATdepending on whether the request is a
1.0or1.1response.Rolls forward the PayID protocol server version to
1.1.Context of Change
Makes ACH -> FIAT
addressDetailsTypechange non-breaking.Type of Change
Before / After
We know do some backwards compatibility stuff.
Test Plan
I fixed all existing tests, but need to add more test coverage now in a
subsequent PR.