This repository was archived by the owner on Mar 8, 2024. It is now read-only.
Add version to payment information #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xASK
reviewed
Aug 18, 2020
|
|
||
| const USER = '/alice' | ||
| const PAYID = `${USER.slice(1)}$127.0.0.1` | ||
| const VERSION = '1.1' |
Collaborator
There was a problem hiding this comment.
Can we establish a global const like this one in the rest of the test files in this PR so that we are always using VERSION instead of typing out '1.1' for each?
Member
There was a problem hiding this comment.
Any chance we can do this refactor in a subsequent PR so we can get this release cut?
Member
|
Actually one comment - I noticed that you mentioned we don't need version negotiation. That means that when we go from 1.x to 2.0, we are going to break the network, right? |
0xASK
approved these changes
Aug 18, 2020
0xASK
pushed a commit
that referenced
this pull request
Aug 18, 2020
Co-authored-by: Dino Rodriguez <dinoorodriguez@gmail.com>
sasaki-san
pushed a commit
to jxpug/payid-serverless
that referenced
this pull request
Nov 16, 2020
Co-authored-by: Dino Rodriguez <dinoorodriguez@gmail.com>
sasaki-san
added a commit
to jxpug/payid-serverless
that referenced
this pull request
Nov 16, 2020
This reverts commit f79115d.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Adds a
versionkey to the PaymentInformation response payload.Context of Change
This is needed to cut the
PayID-VersionandPayID-Server-Versionheaders from the PayID Protocol when we hit 2.0. I spoke with Aanchal about versioning, and she and I came to the conclusion that (for the moment) we don't even need version negotiation, so we don't need to build out versioning in the PayID Discovery WebFinger JRD like I suggested. You can get all the information you need to know from theversionkey in the payload itself, and (hopefully) there shouldn't be many major version changes for the foreseeable future after we cut 2.0.Type of Change
Before / After
The PaymentInformation response payload now includes a
versionkey of the formversion: MAJOR.MINOR.Test Plan
Tests have been updated and all tests pass.