Skip to content

chore: Completed test, Fixed advances#6

Merged
7maylord merged 1 commit into
devfrom
Olumide
Apr 24, 2025
Merged

chore: Completed test, Fixed advances#6
7maylord merged 1 commit into
devfrom
Olumide

Conversation

@7maylord
Copy link
Copy Markdown
Collaborator

1 Fee Calculation Fixes

  • Updated fee calculation logic in tests to properly handle net vs gross amounts
  • Fixed rounding issues in fee calculations that were causing 1 wei discrepancies
  • Added proper handling of fees in batch disbursement tests
  1. Custom Error Handling
  • Replaced string error messages with proper custom error selectors
  • Added missing imports for CustomErrors library
  • Updated revert tests to use correct error selectors:
  1. Test Assertions
  • Fixed balance assertions to account for fee deductions
  • Updated event emission tests to match contract behavior
  • Added proper fee collector balance checks
  1. Testing
  • All tests now pass successfully
  • Improved test coverage for edge cases

@7maylord 7maylord merged commit cd6db15 into dev Apr 24, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant