fix: reset terminal on early quit (Esc/Ctrl+C) in tmux#62
Merged
Conversation
When quitting via Esc or Ctrl+C, reset_terminal() was not being called, leaving the terminal in raw mode with hidden cursor. This only manifested in tmux where terminal state is more strictly managed. Now calls reset_terminal() when game.quit is true (early exit path), not just when the game runs to completion.
Pazl27
approved these changes
May 20, 2026
Owner
Pazl27
left a comment
Pazl27
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Terminal left in raw mode on early quit
Issue: #1 Bug: Terminal output
When quitting via Esc or Ctrl+C (before timer expires), reset_terminal() was not being called, leaving the terminal in raw mode with hidden cursor. This manifests in tmux where terminal state is managed more strictly.
Root cause: In the run() function, reset_terminal() was only called after the normal completion path. The early-quit path (setting game.quit = true) broke out of the loop without resetting terminal state.
Fix: Move reset_terminal() into an else block so it runs on early quit as well.