Skip to content

Fix links to documentation#53

Closed
MarvinJ wants to merge 6 commits intoPecanProject:masterfrom
MarvinJ:master
Closed

Fix links to documentation#53
MarvinJ wants to merge 6 commits intoPecanProject:masterfrom
MarvinJ:master

Conversation

@MarvinJ
Copy link
Copy Markdown
Contributor

@MarvinJ MarvinJ commented May 28, 2014

No description provided.

Comment thread app/views/layouts/application.html.erb Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only one of the four links that has target="_blank", which makes the the linked-to page open up in a new tab or window. Please use this on the other three links as well!

If you merge this edit, it should update #53 with the fixes suggested by @gsrohde
@dlebauer
Copy link
Copy Markdown
Member

dlebauer commented Jun 4, 2014

@MarvinJ please pull MarvinJ/bety#1 and reassign to @gsrohde

@dlebauer dlebauer changed the title Fix link Fix links to documentation Jun 4, 2014
fixed indentation and open links in new window
@dlebauer dlebauer assigned gsrohde and unassigned MarvinJ Jun 4, 2014
@dlebauer
Copy link
Copy Markdown
Member

dlebauer commented Jun 4, 2014

@gsrohde except for a single space of code indenting, this should be ready to merge

Comment thread app/views/layouts/application.html.erb Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usual style for HTML attributes is to have no spaces around the "=" sign, like this:

<a href="https://www.authorea.com/users/5574/articles/6800/_show_article" target="_blank">

(You had it correct for the target="_blank" attribute.)

(By the way, in programming code, you do generally want spaces around the "=" sign, for example:

a = 8 * 9

)

@gsrohde
Copy link
Copy Markdown
Contributor

gsrohde commented Jun 6, 2014

Pulled manually with one slight modification.

@gsrohde gsrohde closed this Jun 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants