Logger: setters return old value, coerce all msg components to string before concatenating#3589
Merged
dlebauer merged 13 commits intoPecanProject:developfrom Aug 6, 2025
Merged
Conversation
dlebauer
requested changes
Aug 6, 2025
Member
dlebauer
left a comment
There was a problem hiding this comment.
LGTM
TOOD: either merge documentation suggestions in infotroph#11 or let me know and I can point it to develop.
Co-authored-by: Chris Black <chris@ckblack.org>
Co-authored-by: Chris Black <chris@ckblack.org>
Co-authored-by: Chris Black <chris@ckblack.org>
Co-authored-by: Chris Black <chris@ckblack.org>
Co-authored-by: Chris Black <chris@ckblack.org>
Ensure docs are complete and correct with respect to SEVERE vs ERROR
Merged
via the queue into
PecanProject:develop
with commit Aug 6, 2025
198010c
18 of 25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Setters return old value
logger.set*(op)now invisibly returns the value ofopthat was in effect before the call, for ease of undoing temporary changes by the same pattern you might know fromop <- options(...); on.exit(options(op)). I found I was wanting this to keep state clean during testing.More robust string conversion
Cases where the message is composed from objects of mixed type now convert each argument to a string before concatenating them.
Before:
After:
Also
Motivation and Context
Review Time Estimate
Types of changes
Checklist: